After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 382923 - libgnomeui doesn't build with non-X11 GDK backend
libgnomeui doesn't build with non-X11 GDK backend
Status: RESOLVED OBSOLETE
Product: libgnomeui
Classification: Deprecated
Component: general
2.16.x
Other Mac OS
: Normal normal
: future
Assigned To: libgnomeui maintainers
libgnomeui maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-06 08:33 UTC by Min Sik Kim
Modified: 2007-07-29 14:33 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Patch to build libgnomeui with non-X11 GDK backend (410 bytes, patch)
2006-12-06 08:34 UTC, Min Sik Kim
none Details | Review

Description Min Sik Kim 2006-12-06 08:33:42 UTC
libgnomeui doesn't build when Gtk is compiled with a non-X11 backend, because it calls an X11 function (XUngrabServer) directly.  The code in libgnomeui/gnome-ui-init.c must be guarded with #ifdef GDK_WINDOWING_X11.
Comment 1 Min Sik Kim 2006-12-06 08:34:41 UTC
Created attachment 77794 [details] [review]
Patch to build libgnomeui with non-X11 GDK backend
Comment 2 Kjartan Maraas 2006-12-09 13:16:37 UTC
Would like to get a comment from one of the gtk+ developers on this, Matthias?
Comment 3 Matthias Clasen 2006-12-09 15:10:17 UTC
The one obvious question is: where is the corresponding XGrabServer call, and why is it not similarly treated by the patch ? Or is it already ifdefed ?
Also, I assume there must be #includes that must be protected somehow, say
by #ifdef HAVE_X11_H or something. 

Other than that, the patch looks like a step in the right direction wrt to compilining libgnomeui on non-X11. Didn't tml already do all this work, btw ?
Or maybe we just regressed.
Comment 4 Tor Lillqvist 2006-12-10 09:14:35 UTC
Is the reporter using GTK built for what backend and on what platform?

On native Win32 (G_OS_WIN32), the whole segv handling including ungrabbing the X11 server stuff is indeed ifdeffed out.

So if the reporter for instance has GTK for the frame buffer backend, the patch is needed.
Comment 5 Min Sik Kim 2006-12-10 15:25:31 UTC
The libgnomeui source doesn't contain any XGrabServer call.  That's why I simply ifdefed the XUngrabServer call.

I was using the Quartz GDK backend.
Comment 6 Kjartan Maraas 2007-01-23 09:54:47 UTC
The XUngrabServer() call was added as a fix for bug 129930 as a suggestion from Mark.
Comment 7 Kjartan Maraas 2007-02-02 13:42:59 UTC
So, does anyone have objections to this patch going in?
Comment 8 Christian Persch 2007-05-29 12:26:58 UTC
The patch looks fine to me.
Comment 9 Kjartan Maraas 2007-06-24 12:38:18 UTC
Let's get it in on trunk then.
Comment 10 Christian Persch 2007-07-29 14:33:40 UTC
The segv handler has been removed on trunk, making this patch obsolete.