GNOME Bugzilla – Bug 382811
Add initial rough support for chatrooms (MUC)
Last modified: 2006-12-17 19:18:34 UTC
The patch is coming as well as new files
Created attachment 77768 [details] [review] gossip-tp-chatrooms.diff This is the path for existing code. It basically now calls the gossip-chatrooms files instead of not implementing chatrooms functions. Also some message foo is needed to differentiate between regular text and MUC messages.
Created attachment 77769 [details] protocols/telepathy/gossip-telepathy-chatrooms.c protocols/telepathy/gossip-telepathy-chatrooms.c The implementation of some support. Join and talking mostly. And not very stable :)
Created attachment 77770 [details] protocols/telepathy/gossip-telepathy-chatrooms.h protocols/telepathy/gossip-telepathy-chatrooms.h Header file
Nice work ! I fixed the indentation. I have some questions: 1) You create a TelepathyMessageData structur ... it's never freed ? 2) in telepathy_message_ack_pending() messages_list is never freed ? 3) In telepathy_send_message() you remove this: - dbus_g_proxy_connect_signal (DBUS_G_PROXY (text_chan), - "Closed", - G_CALLBACK (telepathy_channel_closed_cb), - telepathy, - NULL); Why ? We still need closing channels, how is it removed from the priv->text_channels hash_table ? 4) In gossip_telepathy_chatrooms_join() why did you comment the code which specify on which server we want the chatroom ? Actually we can't say which server we want as I understand ? room_handles and room_object_path are not freed ? The callback isn't called if there is an error, so I guess the UI will wait indefinitely ? 5) I can connect to irc.freenode.net using tp-idle, but gossip crash when I want to join a room: #
+ Trace 92024
I committed your code like that we have an initial code base on which we can continue to work. I added FIXME comments in the code for the above questions.
The crash is now fixed.
Everything should be fixed now, closing this bug :D