After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 381679 - Request that the last.fm plugin have a "record to profile" toggle
Request that the last.fm plugin have a "record to profile" toggle
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: last.fm
HEAD
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 360059 597208 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-12-02 19:37 UTC by Matt N
Modified: 2010-09-21 22:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds a "record to profile" option to the last.fm source window (2.34 KB, patch)
2006-12-02 19:39 UTC, Matt N
needs-work Details | Review

Description Matt N 2006-12-02 19:37:33 UTC
I saw this request on the mailing list and decided it was easy enough to add.
Comment 1 Matt N 2006-12-02 19:39:11 UTC
Created attachment 77550 [details] [review]
Adds a "record to profile" option to the last.fm source window
Comment 2 Jonathan Matthew 2006-12-02 22:21:55 UTC
I think the checkbox would be better placed in the plugin configuration dialog, rather than in the source itself.  It doesn't seem like the sort of thing that would be changed all that often.
Comment 3 Matt N 2006-12-02 22:35:12 UTC
I don't know, it strikes me as the sort of thing some people might use fairly often.  Part of the magic of last.fm is being able to explore new music, and some people might want to turn off the recording while they're trying out things.  I suppose more input from people would be good.
Comment 4 Jonathan Matthew 2006-12-02 23:06:09 UTC
I admit my opinion on this is influenced by the fact that I would never use this option.  I really don't understand concerns about "polluting" of profiles.
Comment 5 Jonathan Matthew 2006-12-02 23:46:59 UTC
That aside, it'd be nice to have the setting persist across sessions.  Does last.fm remember whether you've disabled recording to profile, or does it always start out enabled when you do a new handshake?

If last.fm remembers it and there's a way to check if recording to profile is enabled, we can just sync the checkbox with the server after doing a handshake.

Otherwise, we should store the value in gconf and issue the disable/enable command after the handshake.
Comment 6 Mathias Nedrebø 2006-12-03 15:07:30 UTC
This patch works great, exactly what I was thinking about! About the UI, I think putting it in the plugin preference would be the best option, or just leave it available through gconf. But I'm not sure, I'm just going to check it once and then leave it, others may use it regulary as already mentioned in this thread.
Comment 7 Alex Lancaster 2006-12-13 16:22:34 UTC
*** Bug 360059 has been marked as a duplicate of this bug. ***
Comment 8 Christophe Fergeau 2007-05-06 12:27:42 UTC
Wouldn't it be as easy to disable the last.fm plugin instead of going to the plugin configuration dialog to check/uncheck a "don't send data to lastfm" checkbox ?
Comment 9 Jonathan Matthew 2007-05-06 12:59:11 UTC
This only affects songs played in last.fm streams, so disabling the plugin isn't really an option.
Comment 10 Jonathan Matthew 2008-06-27 23:52:09 UTC
The mechanism used here doesn't work any more - with the playlist-based last.fm streaming scheme, the client submits the songs it plays.

With that in mind, I think it makes more sense to have an option that disables song submission entirely.
Comment 11 Jonathan Matthew 2009-10-03 13:59:50 UTC
*** Bug 597208 has been marked as a duplicate of this bug. ***
Comment 12 Jonathan Matthew 2010-09-21 22:57:00 UTC
This was added as part of Jamie Nicol's summer of code project.