After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 381301 - [patch] Make GstBus watch work with any GMainContext
[patch] Make GstBus watch work with any GMainContext
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.10.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-12-01 15:33 UTC by Wim Taymans
Modified: 2007-02-27 17:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch (15.47 KB, patch)
2006-12-01 15:39 UTC, Wim Taymans 		rejected Details | Review
alternative patch (4.43 KB, patch)
2007-02-27 16:42 UTC, Wim Taymans 		committed Details | Review

Description Wim Taymans 2006-12-01 15:33:46 UTC 
The GstBus watch only works when added to the default GMainContext because it only wakes up the default context when a message is added. This patch keeps track of the sources and wakes up all the contexts they are added too.
Comment 1 Wim Taymans 2006-12-01 15:39:29 UTC 
Created attachment 77490 [details] [review]
the patch
Comment 2 Jan Schmidt 2006-12-08 15:31:12 UTC 
This patch doesn't solve the problem of multiple simultaneous sources listening on the bus, although I know we chatted about that. 

Are you going to address that, or just stick with this patch?
Comment 3 Wim Taymans 2006-12-08 16:41:18 UTC 
the multiple sources is vastly more complicated. This patch simply attempts to solve a different problem first.
Comment 4 Wim Taymans 2007-02-27 16:41:06 UTC 
The patch also has races and looks too complicated.
Comment 5 Wim Taymans 2007-02-27 16:42:40 UTC 
Created attachment 83476 [details] [review]
alternative patch

This is an alternative patch that allows me to do what I want, ie, poll the bus from another thread.
Comment 6 Jan Schmidt 2007-02-27 17:16:30 UTC 
I like this patch
Comment 7 Wim Taymans 2007-02-27 17:43:40 UTC 
did you also spot the bug? :)