GNOME Bugzilla – Bug 380958
make the shown information of a picture configurable
Last modified: 2008-09-28 15:21:29 UTC
Hi, at the left-down f-spot shows some information of the selected picture. It would be nice, if the user can configure which exifs-entries are shown there.
Created attachment 105938 [details] [review] patch (rev 3708) Hi, I created a patch for this. I added some information to display in the infobox, which are useful for me. You can choose, what information is displayed under view->photo information Mike
Created attachment 105939 [details] screenshot And here is a little screenshot with all information.
patch is nice! just a trivial note: your added items have a semicolon before the value, while the original labels hasn't. and another trivial thing: add Changelog entry.
Created attachment 106012 [details] [review] patch (rev 3708) ok, here a new one with changelog and without colon. I found this bug 332027 and so I made the photo name configurable, too. But it is still displayed by default. Mike
Created attachment 117457 [details] [review] patch I reworked the patch for trunk (rev 4300). To change the shown information, a popup menu is used. There is still an issue, because the popup does not work for the displayed labels.
Created attachment 117458 [details] screenshot here is a little screenshot.
Some comments (line numbers refer to line numbers of the diff): * Why did you remove the call to UpdateHistogram on line 68? * Doesn't apply anymore because of todays changes (sorry for that) * There's some style issues on lines 109 -> 111, looks ugly You'll have to rework it, as INFOBOX_INFO_VISIBLE and INFOBOX_HISTOGRAM_VISIBLE are no longer used. For the rest, I like it and it looks good. So it's almost ready to get it in. And finally: the issue you mention in comment 5, is it fixable, or shall we just accept and ignore it?
Hi, thx for looking at the path. 1) there was a reason, why it is not needed anymore. But I do not remember now, I will look at the code and tell you the reason later. 2) ok :) 3) This was the soultion from sde, to apply the popup and ignore the labels in the box. I'll try to fix this issue soon.
Created attachment 119082 [details] [review] Patch I reworked the path to work with trunk. 1) The UpdateHistogram on line 68 from the old patch was removed, because I used the callback Preferences.SettingsChanged to take care about changes. This would cause two updates of the histogram, so this line was removed. The new patch, doesn't use this callback, because it does not fit to the last changes with the Strategy. 2) The thing with the labels was fixed, I'll post a screenshot right now. 3) A new Problem arised. To fix the popup for all labels I used an EventBox-Widget. But this causes a darker gray box in the overlay of the fullscreen-view. Maybe someone, who is more familar with the tranparency things can look at it. I'll additionally try to fix it. 4) Another question is, who to handle the recently added Tag- and Rating-View in fullscreen? make it also configurale? leave it, as it is? comments are welcome.
Created attachment 119083 [details] screenshot and here is the proposed screenshot
Created attachment 119087 [details] [review] patch I uploaded the wrong file. Here is the right one.
Created attachment 119488 [details] [review] patch The last patch didn't apply with the last changes in InfoBox.cs. So here is an updated version.
committed. Mike, please think about discussing the overlay issue with me on irc one of these days.