After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 380610 - [rganalysis] Incorrect event handling
[rganalysis] Incorrect event handling
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.4
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-29 18:57 UTC by René Stadler
Modified: 2006-11-30 15:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix event handling in rganalysis element (330 bytes, patch)
2006-11-29 19:00 UTC, René Stadler 		committed Details | Review

Description René Stadler 2006-11-29 18:57:49 UTC 
The rganalysis element from the replaygain plugin does not call BaseTransform's base handler for the "event" vfunc.  I suppose this breaks QOS.  Should BaseTransform be changed to do the push_event in the base handler, this would have more severe consequences (there is a FIXME in the code that suggests this).

I forgot to include the call to the base handler because it is the only vfunc (besides src_event) that is not "hook-style" (the other base handlers do nothing and are meant to be overridden completely).  As I don't have write access to the repository, someone has to apply the single line fix I will attach.  Sorry for the inconvenience.
Comment 1 René Stadler 2006-11-29 19:00:52 UTC 
Created attachment 77363 [details] [review]
Fix event handling in rganalysis element


        * gst/replaygain/gstrganalysis.c: (gst_rg_analysis_event):
          Call the base class handler.  Fixes #380610.