GNOME Bugzilla – Bug 380396
gsf_xml_gvalue_from_str() doesn't deal with enums/flags correctly
Last modified: 2006-12-01 18:23:03 UTC
From the Gnumeric list [1]: The attached patch fixes the G_TYPE_ENUM/G_TYPE_FLAGS saving/restoring to/from XML streams. Previously, the libgsf routines glade_enum_from_string and glade_flags_from_string were unable to determine the enum/flags type, which is required to look up strings like "FOO_FLAGS_BAR" against the "FooFlags" type. Not passing fundamental types to the libgsf helper in goffice didn't have any negative consequences for me so far, and it shouldn't unless we have non-GObject, non-flags and non-enum (i.e. weird) types that are not fundamentals. I've added some debugging code for the purpose of determining such issues. [1] http://mail.gnome.org/archives/gnumeric-list/2006-November/msg00019.html
Created attachment 77323 [details] [review] libgsf patch
Created attachment 77324 [details] [review] goffice patch
Comment on attachment 77323 [details] [review] libgsf patch Good catch. Please commit
Comment on attachment 77324 [details] [review] goffice patch ditto.
Committed, closing.