GNOME Bugzilla – Bug 380373
Add birthday support to contact information
Last modified: 2006-12-09 22:24:02 UTC
Add support to view and edit birthday information for contacts
Created attachment 77320 [details] [review] Patch If someone (zdra!!) can review this... thanks
I think it's not really the moment to make such protocol-dependent changes. GossipVCard will for sure need a big rework (if not completely removed) to fit telepathy spec for contact information. Telepathy doesn't have a spec for that yet, so I suggest to wait until we can design a new API. I think it will be the same than for GossipAccount, static information will move to a dynamic GHashTable. Why is there that many changes in the glade ? I didn't looked at what it looks but the patch seems huge...
I took a look at this too. My comments: - I don't think the birthday needs to be in the contact information dialog. - The birthday entry field in the vcard dialog should be regulated a bit more, i.e. having separate fields for YYYY-MM-DD and enforcing that - although the Jabber spec doesn't have any outline for the format but they do use the one I just mentioned. - I agree with Xavier, the glade files are quite large. This might be because I removed a dialog in the main.glade file recently and your version was the older version - there certainly shouldn't be that many changes considering the bug this fixes. - I would like to see the birthday used in some way. For example, compositing a birthday icon (like a crown) over the status icon for people that you know have a birthday that day. Xavier: - Remember we are not just working to be completely compatible with Telepathy, we can still write Jabber specific software, I really don't think waiting for a Telepathy spec on ANYTHING is a good enough reason to decline a patch. - VCards are somewhat of a standard in themselves anyway, so I wouldn't worry about what Telepathy does, because it is likely to be similar. - By committing such patches we can learn from them and improve our recommendations to the Telepathy team when they ask about how best to implement some spec to do the same thing.
About the huge diff for the glade file, my bad, I use glade-3 to edit this :/ About the formatting of the date, I have seen in the jep's that the date must be formatted according to ISO 8601, but AFAIK there is only a few client that enforce this. So it could be a problem for a "today birthday" feature... To make gossip enforces this format, we could use a gtkCalendar or something like that to set the field? >- I don't think the birthday needs to be in the contact information dialog. Where do you would like to see this info?
Please, don't use glade-3 for editing any glade files, it doesn't work properly yet. We had this a while back, so if you are doing any patches, use glade-2 otherwise they won't be accepted :) I thought about using the GtkCalendar, but it is a big widget and in the end we just duplicate the gnome-about-me dialog if we keep adding all these fields. So I propose that we have 3 entries: [YYYY] [MM] [DD] [Browse] Where the browse button shows a GtkCalendar perhaps? I don't really know how this information is useful other than showing your friend's birthdays, on the roster or something. Putting it in the contact information dialog is ok, but I don't really see the point. I guess we could have it there. As for enforcing the format in that field, I am not worried about that, other clients data that doesn't comply just won't be used I should imagine. The patch would need a lot more work for this of course, i.e. entries would only accept digits and the vcard data would have to be checked, etc.
Created attachment 77382 [details] Screenshot What do you think of something like that?
Created attachment 77383 [details] Screenshot calendar The 3 dot button open a simple gtkcalendar like that
Laurent: Yea, something like that (I really meant separate entries for YYYY, MM and DD, but I am not really sure). Except I would rather it was a drop down type object instead of a new window (a bit like the presence combo on the main window) so we don't have to worry about a new window with an OK button. That said, I would still rather have the separate dialog than just an entry :) What would be ideal would be a new widget called GossipCalendarButton or something which does the "..." and also (while pressed) shows a popup with the GtkCalendar inside it. I think Evolution do this as a custom widget. It is a bit more work, but it would be handy in other places then. I wonder if it would be better as just a label with the button so you can select it (a selectable label of course). And I think we should have the DOB in the contact information - it could be good to have.
Created attachment 77393 [details] [review] Patch with gtkcalendar >I wonder if it would be better as just a label with the button so you can >select it (a selectable label of course). Well I made the text entry read-only, I find the text entry prettier :) About creating a new widget, I think I don't have the skills yet.. :(
Thanks for the patch. I changed the whole dialog anyway, but at least we know have birthday support.