GNOME Bugzilla – Bug 379919
Port HEAD to use EogJobQueue
Last modified: 2007-03-18 00:11:24 UTC
I've being working on (back)porting HEAD to use the EogJobQueue code, found in eog-ng. I already ported all of the jobs but the EogJobSave, and will post a patch here when I am ready. This should fix all the horrible crashers we have. In fact, my current patch does it.
Wootle. Any progress on this?
Sorry for the huge time without reporting about this. This proved to be more tricky than I originally thought. Although the "leave F11 pressed and see EOG crash" bug would be fixed with the port I've done, there are still some other crashers in fullscreen mode not too difficult to trigger and I can't think of any sane way to fix them. I will post a partial patch here later (hopefully today?) for you to try and give me your comments.
Created attachment 78212 [details] [review] partial patch, it is not ready at all. This patch has already ported: - Transformations - Image List loading - Image Loading - Fullscreen mode (*) But there are many ways to make (*) crash, although the "leave F11 pressed" crash seems to be fixed. I still need to port saving, but I won't do that until I am completely sure that all the fullscreen crashes are fixable.
thank you for adressing this. I am not a good coder, but I'll give your patch a test drive.
i assume that we should change the gnome target milestone from 2.18 to 2.20 because of http://blogs.gnome.org/view/lucasr/2007/01/22/0 , right?
Due to my time restriction now that I'm working, I decided to focus my efforts in implementing what's left in eog-ng, so we can merge it after the 2.18 branch. Therefore, I don't think I'll be able to finish this. I'm sorry. Anyway, the good stuff will come in 2.20, and all the ugly crashers will be gone by then.
okay, setting gnome target to 2.20. way too many dups.
eog-ng branch, which has a full rewrite of eog's core, has been merged into trunk as part of 2.19/2.20 development cycle. Therefore this bug can be considered fixed now. Thanks for the report!