After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 379792 - Remove memcpy in multipartmux and fix RFC compliance
Remove memcpy in multipartmux and fix RFC compliance
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 377521 377523 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-11-27 14:44 UTC by Jonas Holmberg
Modified: 2006-11-27 16:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
First attempt patch (3.19 KB, patch)
2006-11-27 14:48 UTC, Jonas Holmberg 		committed Details | Review

Description Jonas Holmberg 2006-11-27 14:44:59 UTC 
* push header in a separate buffer instead of memcpy:ing all data
* change LF => CRLF in headers
* move trailing LF to header
Comment 1 Jonas Holmberg 2006-11-27 14:48:23 UTC 
Created attachment 77214 [details] [review]
First attempt patch

Includes fixes for all three bullets in report
Comment 2 Jonas Holmberg 2006-11-27 14:51:00 UTC 
*** Bug 377521 has been marked as a duplicate of this bug. ***
Comment 3 Jonas Holmberg 2006-11-27 14:51:36 UTC 
*** Bug 377523 has been marked as a duplicate of this bug. ***
Comment 4 Wim Taymans 2006-11-27 16:30:30 UTC 
        Patch by: Jonas Holmberg <jonas dot holmberg at axis dot com>

        * gst/multipart/multipartmux.c: (gst_multipart_mux_collected):
        Push header in a separate buffer instead of memcpy:ing all data.
        Change LF => CRLF in headers.
        Move trailing LF to header. Fixes #379792.