After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 379314 - [Patch] Set "profile" property of gconfaudiosink; honour "music/movies" setting
[Patch] Set "profile" property of gconfaudiosink; honour "music/movies" setting
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: playback
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-26 00:41 UTC by Alexander “weej” Jones
Modified: 2006-11-26 21:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to make the gconfaudiosink honour profile settings (6.88 KB, patch)
2006-11-26 00:47 UTC, Alexander “weej” Jones
committed Details | Review

Description Alexander “weej” Jones 2006-11-26 00:41:40 UTC
Patch created to cause Rhythmbox to honour the sound profile settings in GConf.
Comment 1 Alexander “weej” Jones 2006-11-26 00:47:06 UTC
Created attachment 77149 [details] [review]
Patch to make the gconfaudiosink honour profile settings
Comment 2 James "Doc" Livingston 2006-11-26 13:12:12 UTC
Committed to cvs with a small change, checking that the property exists before attempting to set it. Thanks.
Comment 3 Bastien Nocera 2006-11-26 13:35:01 UTC
Are you sure you're checking for the property on the right object?

        if (sink != NULL) {
                /* set the profile property on the gconfaudiosink to "music and movies" */
                if (g_object_class_find_property (G_OBJECT_GET_CLASS (source), "profile"))
                        g_object_set (G_OBJECT (source), "profile", 1, NULL);

                g_object_set (G_OBJECT (mp->priv->playbin), "audio-sink", sink, NULL);
Comment 4 Alexander “weej” Jones 2006-11-26 15:56:35 UTC
I was setting it on sink... that's right, right?
Comment 5 Alexander “weej” Jones 2006-11-26 17:14:39 UTC
Hmm, doesn't even compile now. I think it definitely should have been "sink".

I see the same stuff just went into Totem CVS. (Except that compiles!) :D

Comment 6 Jonathan Matthew 2006-11-26 21:01:29 UTC
fixed.