After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 379148 - Properties dialog should close on Return
Properties dialog should close on Return
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
0.9.6
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-25 14:23 UTC by Sebastien Bacher
Modified: 2006-11-29 08:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
"activates_default" should be True for property dialogues (2.56 KB, patch)
2006-11-26 02:50 UTC, Thomas Thurman 		committed Details | Review

Description Sebastien Bacher 2006-11-25 14:23:22 UTC 
That bug has been opened on https://launchpad.net/distros/ubuntu/+source/rhythmbox/+bug/72734

"Use case:

When using the keyboard to view or change properties, the dialog should be closed when hitting return. The Close button is highlighted by default, which makes it look like it should be activated when pressing return.

This would make especially editing properties much more convenient."
Comment 1 Thomas Thurman 2006-11-26 02:50:51 UTC 
Created attachment 77150 [details] [review]
"activates_default" should be True for property dialogues

This is caused by the "activates_default" property being False on text boxes in the property dialogues' Glade files. The attached patch fixes the problem.
Comment 2 James "Doc" Livingston 2006-11-29 08:52:51 UTC 
Committed to cvs, thanks.

For future reference, passing "-u" to diff or cvs diff (or putting "diff -u" in ~/.cvsrc) causes it to generate unified diffs, which are much more readable.