GNOME Bugzilla – Bug 379085
Iceweasel and Icedove support in preferred apps
Last modified: 2006-12-17 19:07:23 UTC
Hi there, Due to trademark issues (background: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=354622 http://web.glandium.org/blog/?p=97), Debian now ships a browser named IceWeasel which is simply a rebranded Firefox. The same goes for Thunderbird which becomes Icedove. I'll attach a patch for preferred apps to list these alternatives as well; it would be nice if you could merge it in CVS (for translations etc.). Bye,
Created attachment 77120 [details] [review] Add IceWeasel web browser and Icedove mail reader to preferred apps
Created attachment 77122 [details] [review] Add IceWeasel web browser and Icedove mail reader to preferred apps (v2) It's Iceweasel, not IceWeasel.
Loïc, we have bug #326808 opened against thunderbird command line wrong parameters (-compose seems not to fix the problem). Since you have used the -compose option in your patch, does Icedove has the same problem?
I consciously reverted the -compose change to submit this patch because I wanted the patch to apply against CVS. I think the -compose change is still interesting both for thunderbird and icedove.
In this case, wouldn't it be better if we add Icedove with the correct parameters, and then fix only one bug against thunderbird, instead of two? :)
Created attachment 77280 [details] [review] Add IceWeasel web browser and Icedove mail reader to preferred apps, no -compose flag (v3) Yes, please commit Icedove support without the -compose flag.
Sebastien, Rodrigo, is it ok for you to remove the -compose option from icedove/thunderbird? I can't test the patch, sice I don't have those two email clients, but Loïc seems having tested it (see also latest comments in bug #326808).
Patch committed (Loïc, next time provide also a ChangeLog entry, please :)
I'm 50/50 on changelog entries, especially when patches might sit relatively long in the BTS. Changelog entries in an unified diff will always conflict if anything else has been committed inbetween.
Yup, you are right, but in this case the ChangeLog entry can be stripped-off and then manually applied... Yes, I know, I'm too lazy :)