After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 378394 - gimp-vectors-new-from-* return IDs, not PDB_VECTORs
gimp-vectors-new-from-* return IDs, not PDB_VECTORs
Status: RESOLVED INVALID
Product: GIMP
Classification: Other
Component: libgimp
git master
Other All
: Normal normal
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-11-23 06:51 UTC by david gowers
Modified: 2006-11-23 21:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description david gowers 2006-11-23 06:51:25 UTC 
This is oddly inconsistent- every other gimp-vectors function, including gimp-vectors-new, uses PDB_VECTORs.
Comment 1 Sven Neumann 2006-11-23 07:04:36 UTC 
A PDB_VECTOR is an ID. There's nothing inconsistent here.
Comment 2 Manish Singh 2006-11-23 07:11:08 UTC 
To elaborate, gimp-vectors-new-from-* returns *multiple* IDs, and there's no array type for vectors (nor images, nor drawables, etc.). This is consistent with gimp-image-list or gimp-image-get-channels, etc.
Comment 3 Simon Budig 2006-11-23 09:38:37 UTC 
We could simply rename them gimp-vectors-import-from-*  or gimp-vectors-load-from-*. The reason of course is that a SVG-file/string can contain multiple paths.
Comment 4 Sven Neumann 2006-11-23 17:28:40 UTC 
Hmm, perhaps it would indeed make sense to rename the functions to avoid confusion with other gimp-vectors-new constructors.
Comment 5 Simon Budig 2006-11-23 21:46:42 UTC 
I have renamed these functions:

2006-11-23  Simon Budig  <simon@gimp.org>

        * tools/pdbgen/pdb/vectors.pdb: renamed gimp_vectors_new_from_*
        to gimp_vectors_import_from_*, as discussed in bug #378394.

        * plug-ins/common/svg.c
        * libgimp/gimp.def: changed accordingly.

        * libgimp/gimpvectors_pdb.[ch]
        * app/pdb/vectors_cmds.c: regenerated.