After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 377981 - use of g_random_double_range() in gimpbrushcore.c
use of g_random_double_range() in gimpbrushcore.c
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other All
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-11-22 02:56 UTC by Adrian Likins
Modified: 2006-11-22 20:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to replace g_random_double_range with g_rand_double_range (1.24 KB, patch)
2006-11-22 02:58 UTC, Adrian Likins 		none Details | Review
patch to add a GRand to gimpbrushcore and use it (2.24 KB, patch)
2006-11-22 19:41 UTC, Adrian Likins 		committed Details | Review

Description Adrian Likins 2006-11-22 02:56:37 UTC 
mitch says use of g_rand_double_range is prefered over g_random_double_range() 
so this patch fixes it in gimpbrushcore.c
Comment 1 Adrian Likins 2006-11-22 02:58:00 UTC 
Created attachment 77009 [details] [review]
patch to replace g_random_double_range with g_rand_double_range
Comment 2 Sven Neumann 2006-11-22 08:08:43 UTC 
The random number generator should become part of the GimpBrushCore object so that it doesn't need to be initialized every so often.
Comment 3 Adrian Likins 2006-11-22 19:41:16 UTC 
Created attachment 77035 [details] [review]
patch to add a GRand to gimpbrushcore and use it

GRand added to gimpbrushcore
Comment 4 Michael Natterer 2006-11-22 20:23:26 UTC 
Fixed in CVS:

2006-11-22  Michael Natterer  <mitch@gimp.org>

	* app/paint/gimpbrushcore.[ch]: applied modified patch from Adrian
	Likins which adds a GRand to the GimpBrushCore struct and uses it
	instead of using g_random_foo() functions. Fixes bug #377981.