After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 377885 - Cannot drag and drop from smart playlist into iPod
Cannot drag and drop from smart playlist into iPod
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Smart Playlists
0.11.0
Other All
: Normal normal
: 2.x
Assigned To: Gabriel Burt
Gabriel Burt
Depends on:
Blocks:
 
 
Reported: 2006-11-21 19:40 UTC by Paul Glover
Modified: 2007-01-17 01:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
SourceView.cs.diff to allow drag&drop with smart playlists (328 bytes, patch)
2006-12-11 22:04 UTC, Chris Turchin
committed Details | Review

Description Paul Glover 2006-11-21 19:40:42 UTC
Please describe the problem:
Created a smart playlist for refilling an iPod shuffle. The playlist is filled, and the tracks selected, but when they're dragged over the iPod entry in the sidebar, tracks are not copied onto the iPod.

Steps to reproduce:
1. Plug in an iPod so that it appears in the Banshee sidebar.
2. Create a smart playlist.
3. Go to the smart playlist and select one or more tracks which aren't on the iPod already.
4. Drag and drop the selected tracks onto the iPod sidebar entry.
5. Go to the iPod playlist to confirm if the track(s) were added.

Actual results:
On "drop", the tracks "spring back" from the mouse pointer into the main playlist window (in the same way that files would if they'd been dragged and dropped back to where they came from, or to somewhere that files could not be dropped). Nothing is copied onto the iPod and I'm forced to use gtkpod instead.

Expected results:
Tracks are added to the iPod's playlist, ready to be sync'ed. Gtkpod gets uninstalled.

Does this happen every time?
Yes

Other information:
Dragging from the smart playlist and dropping to the desktop, or a Nautilus window, is working and makes a copy of the selected tracks.

Dragging tracks from the "whole library" list into the iPod works as expected.

Could the drop areas in the UI be wrong when viewing the smart playlist, causing Banshee to think that I'm dropping the tracks back into the playlist they're already in?
Comment 1 Manuel Martín Salvador 2006-12-04 22:53:40 UTC
I have the same problem. :(
Comment 2 Chris Turchin 2006-12-11 20:11:42 UTC
this issue tangentally related to bug:

Comment 3 Chris Turchin 2006-12-11 22:04:19 UTC
Created attachment 78168 [details] [review]
SourceView.cs.diff to allow drag&drop with smart playlists

SourceView.cs.diff to allow drag&drop with smart playlists
Comment 4 Chris Turchin 2006-12-11 22:05:50 UTC
this is resolved by this simple patch:

Index: src/Banshee.Base/Gui/SourceView.cs
===================================================================
RCS file: /cvs/gnome/banshee/src/Banshee.Base/Gui/SourceView.cs,v
retrieving revision 1.62
diff -r1.62 SourceView.cs
415a416
>                 SourceManager.ActiveSource is Banshee.SmartPlaylist.SmartPlaylistSource ||


but this introduces a kind of race condition when the user selects data from a smart playlist and wants to copy it to someplace else and the smart playlist refreshes while the drag event is in progress. however, i cannot even get this to reproducibly occur. and this condition is cleanly handled with this code:

LogCore.Instance.PushError(Catalog.GetString("Could not import tracks"), e.Message);

at line 514 of SourceView.cs...



Comment 5 Manuel Martín Salvador 2006-12-12 10:39:18 UTC
Works great! Thank you very much! :D
Comment 6 Josiah Ritchie - flickerfly 2007-01-03 15:46:36 UTC
Is there any chance that this would also work with Mass Storage USB DAPs?
Comment 7 Gabriel Burt 2007-01-17 01:12:55 UTC
Committed, thanks.  Chris, next time please generate unified diffs (cvs diff -u, though irrelevant now since svn diff automatically makes them).