After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 376952 - Wrong spinner size
Wrong spinner size
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 373686 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-11-19 11:27 UTC by Michael Monreal
Modified: 2006-12-12 17:09 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Screenshot (66.94 KB, image/png)
2006-11-19 11:29 UTC, Michael Monreal
  Details
patch (6.27 KB, patch)
2006-12-09 19:39 UTC, Christian Persch
none Details | Review
better and correct patch (6.43 KB, patch)
2006-12-09 19:49 UTC, Christian Persch
committed Details | Review

Description Michael Monreal 2006-11-19 11:27:29 UTC
I updated my nautilus installation from 2.16.x (the installation was from jhbuild) to 2.17.x CVS HEAD yesterday. Since then I get strange resizing problems with the toolbar, I think which are connected to the new spinner/throbber code.

I use the following in ~/.gnome2/nautilusrc

gtk-icon-sizes="gtk-large-toolbar=16,16"

This changes the toolbar to use 16x16 icons instead of 24x24 icons. The same can also be done in gconf desktop wide and also as a theme option in an gtkrc file so I think this should work.

Anyway, after booting and calling nautilus from the places menu -> Home I see that the spinner is BIG and the toolbar is taller than it should to make room for the spinner. I tried various things, such as xkill'ing nautilus. After that nautilus opens a window which has a correctly sized spinner! but when I open other nautilus windows after that the spineris big again (it stays correct for the window where it started in correct size)
Comment 1 Michael Monreal 2006-11-19 11:29:51 UTC
Created attachment 76836 [details]
Screenshot

This shows the nautilus toolbar after I xkill'ed nautilus (2) and the second window (1) was opened after that using file->new window
Comment 2 Michael Monreal 2006-11-19 11:44:11 UTC
Just tried a workaround, replaced the bitmaps in 16x16 and 24x24 animations directories with empty bitmaps. This disables the spinner for 16x16 but then I realized that the big spinner is in fact from 48x48! Replacing those with 16x16 blank bitmaps makes the spinner disapper in the big state too, but the toolbar is still big - so the toolbar scaling doesn't happen because it tries to fit a too-big icon in it but rather it has a 48x48 box there and displays the fitting icon...
Comment 3 Michael Monreal 2006-11-19 11:52:26 UTC
Ok just to make sure I removed the gtk-icon-sizes "hack" from nautilusrc and I see the same thing, spinner is being displayed at 48x48 where it should be 24x24
Comment 4 Baptiste Mille-Mathias 2006-12-03 10:48:24 UTC
Bug seen and confirmed
Comment 5 Christian Persch 2006-12-09 18:34:19 UTC
I cannot reproduce this in either nautilus or testspinner.
Using the bits in ~/.gtkrc-2.0, the spinner has size 16px in the toolbar in "icons" mode.
Comment 6 Michael Monreal 2006-12-09 18:47:41 UTC
@chep: it happens in both icons and list view... make sure to open a second window after restarting nautilus, the first one has the correclty sized spinner!
Comment 7 Christian Persch 2006-12-09 19:39:33 UTC
Created attachment 78046 [details] [review]
patch

Ah, I missed the '2nd window' bit.

The problem is that the first window always gets a style reset when it's shown, which doesn't happen for subsequent windows.

Attached patch fixes the problem. Only the change to nautilus-window-toolbar.c is necessary for this bug; the change to ephy-spinner simply brings ephy-spinner uptodate with the latest code in epiphany (fixing bug 382207 and bug 374623).
Comment 8 Christian Persch 2006-12-09 19:49:37 UTC
Created attachment 78047 [details] [review]
better and correct patch
Comment 9 Christian Persch 2006-12-11 21:37:05 UTC
*** Bug 373686 has been marked as a duplicate of this bug. ***
Comment 10 Christian Persch 2006-12-12 17:09:11 UTC
Committed to HEAD:

        * src/ephy-spinner.c: 
        * src/ephy-spinner.h: Update from Epiphany. Fixes #374623 and #382207.

        * src/nautilus-window-toolbars.c: Fix wrong spinner size. Bug #376952.