After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 376401 - A new ColorSetting class
A new ColorSetting class
Status: RESOLVED FIXED
Product: lsr
Classification: Deprecated
Component: core
unspecified
Other Linux
: Normal normal
: 0.4.0
Assigned To: Eitan Isaacson
LSR maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-17 18:33 UTC by Eitan Isaacson
Modified: 2006-11-27 17:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ColorSetting (6.81 KB, patch)
2006-11-17 18:35 UTC, Eitan Isaacson 		none Details | Review
Proposed patch (6.70 KB, patch)
2006-11-17 20:53 UTC, Eitan Isaacson 		none Details | Review

Description Eitan Isaacson 2006-11-17 18:33:16 UTC 
This adds a new class called ColorSetting which stores a tuple with 3 or 4 values (depending if alpha is enabled). The values are between 0 and 0xFFFF.
Comment 1 Eitan Isaacson 2006-11-17 18:35:55 UTC 
Created attachment 76775 [details] [review]
ColorSetting

ColorSetting class and widget factory.
Comment 2 Peter Parente 2006-11-17 19:49:57 UTC 
Eitan,

Do we need the explicit has_alpha flag? Or can the widget factory determine that the alpha is present simply from the size of the color tuple? (length 3 versus 4)
Comment 3 Eitan Isaacson 2006-11-17 20:53:51 UTC 
Created attachment 76779 [details] [review]
Proposed patch

That's a great idea!
Comment 4 Peter Parente 2006-11-27 17:31:13 UTC 
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.