GNOME Bugzilla – Bug 375264
[neonhttpsrc] add seek support
Last modified: 2006-12-24 14:22:52 UTC
The following patch enables seek support on GstNeonhttpSrc. It also contains some cleanups and memory management improvements.
Created attachment 76589 [details] [review] GstNeonhttpSrc seek support
Could you submit a patch that just adds the functionality? You can always submit a renaming patch later.
Hi Andre and Lutz, I have just commited it.
Edgard: in general, if someone raises objections to a patch, you shouldn't just commit it without further discussion. It usually is better to do multiple separate commits for cleanups and functionality, since it makes tracking down regressions and bugs much easier and it makes reviewing commits/patches easier as well.
This bit is going to generate a compiler warning: @@ -60,34 +66,41 @@ PROP_IRADIO_NAME, PROP_IRADIO_GENRE, PROP_IRADIO_URL, - PROP_NEON_HTTP_REDIRECT + PROP_NEON_HTTP_REDIRECT, #ifndef GST_DISABLE_GST_DEBUG - , PROP_NEON_HTTP_DBG + PROP_NEON_HTTP_DBG #endif };