After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 375264 - [neonhttpsrc] add seek support
[neonhttpsrc] add seek support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-14 19:59 UTC by Andre Moreira Magalhaes
Modified: 2006-12-24 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
GstNeonhttpSrc seek support (35.96 KB, patch)
2006-11-14 20:01 UTC, Andre Moreira Magalhaes
committed Details | Review

Description Andre Moreira Magalhaes 2006-11-14 19:59:33 UTC
The following patch enables seek support on GstNeonhttpSrc. It also contains some cleanups and memory management improvements.
Comment 1 Andre Moreira Magalhaes 2006-11-14 20:01:46 UTC
Created attachment 76589 [details] [review]
GstNeonhttpSrc seek support
Comment 2 Lutz Mueller 2006-12-20 21:28:58 UTC
Could you submit a patch that just adds the functionality? You can always submit a renaming patch later.
Comment 3 Edgard Lima 2006-12-22 16:24:48 UTC
Hi Andre and Lutz,

I have just commited it.
Comment 4 Tim-Philipp Müller 2006-12-24 11:33:00 UTC
Edgard: in general, if someone raises objections to a patch, you shouldn't just commit it without further discussion.

It usually is better to do multiple separate commits for cleanups and functionality, since it makes tracking down regressions and bugs much easier and it makes reviewing commits/patches easier as well.
Comment 5 Jens Granseuer 2006-12-24 14:22:52 UTC
This bit is going to generate a compiler warning:

@@ -60,34 +66,41 @@
   PROP_IRADIO_NAME,
   PROP_IRADIO_GENRE,
   PROP_IRADIO_URL,
-  PROP_NEON_HTTP_REDIRECT
+  PROP_NEON_HTTP_REDIRECT,
 #ifndef GST_DISABLE_GST_DEBUG
-      , PROP_NEON_HTTP_DBG
+  PROP_NEON_HTTP_DBG
 #endif
 };