GNOME Bugzilla – Bug 375234
ipod sync: don't crash if fsusage is NULL
Last modified: 2007-05-14 04:06:13 UTC
What were you doing when the application crashed? I've been trying to sync contacts with iPod iPod have been ejected with `eject /dev/sda2` But still connected with cable to PC Distribution: Debian 4.0 Gnome Release: 2.15.91 2006-08-13 (Debian) BugBuddy Version: 2.16.0 Memory status: size: 164925440 vsize: 0 resident: 164925440 share: 0 rss: 42856448 rss_rlim: 0 CPU usage: start_time: 1163525274 rtime: 0 utime: 2447 stime: 0 cutime:2342 cstime: 0 timeout: 105 it_real_value: 0 frequency: 2 Backtrace was generated from '/usr/bin/evolution-2.8' (no debugging symbols found) Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1". (no debugging symbols found) [Thread debugging using libthread_db enabled] [New Thread -1231869728 (LWP 17554)] [New Thread -1287730256 (LWP 17998)] [New Thread -1279337552 (LWP 17662)] [New Thread -1312908368 (LWP 17652)] [New Thread -1304515664 (LWP 17650)] [New Thread -1321301072 (LWP 17624)] [New Thread -1270678608 (LWP 17610)] [New Thread -1251284048 (LWP 17605)] (no debugging symbols found) 0xffffe410 in __kernel_vsyscall ()
+ Trace 86446
Thanks for the bug report. Unfortunately, that stack trace is not very useful in determining the cause of the crash. Could you please install some debugging packages [1] and reproduce the crash, if possible? Once bug-buddy pops up, you can find the stacktrace in the "details", now containing way more information. Please copy that stacktrace and paste it as a comment here. Thanks! [1] debugging packages for evolution, evolution-data-server and gtkhtml, plus debugging packages for some basic GNOME libs. More details can be found here: http://live.gnome.org/GettingTraces/DistroSpecificInstructions
Created attachment 76646 [details] [review] ipod-sync plugin: don't crash when fsusage variable is NULL This bug appears when iPod is plugged in, but not all info available i.e volume.fsusage P.S. Do we really need this piece of code: if (!libhal_device_property_exists (ctx, udi2, "volume.is_filesystem", NULL) || !libhal_device_get_property_bool (ctx, udi2, "volume.is_filesystem", NULL)) { has_fs = 1; } As i understand volume.fsusage replaced volume.is_filesystem Whith this patch old HAL will not work, because libhal_device_get_property_string will return NULL for volume.fsusage
reopening as per last comment; confirming so a developer hopefully looks on this
Looks harmless and simple.
which is probably a codeword for "Vitaliy, if you have a SVN account, please commit to trunk"...
No, I don't have svn account :)
Committed to head. Needs to go to stable as well.