After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 374831 - Selecting [none] for directory creates a directory of " ".
Selecting [none] for directory creates a directory of " ".
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: ripping
2.16.x
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
: 370297 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-11-13 19:31 UTC by Adam Petaccia
Modified: 2006-12-10 06:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
Doesn't add an extra directory with a space (476 bytes, patch)
2006-11-13 19:32 UTC, Adam Petaccia
accepted-commit_now Details | Review

Description Adam Petaccia 2006-11-13 19:31:19 UTC
Please describe the problem:
If under track names folder heirarchy is set to [none], it still creates a directory, with just a space for its name.

Steps to reproduce:
1)  Set Folder Heirarchy to [none]
2)  Extract a CD

Actual results:
Files are dropped in $BASEFOLDER/\ /$SONGNAME

Expected results:
Files should be put in $BASEFOLDER/$SONGNAME

Does this happen every time?
yes

Other information:
Comment 1 Adam Petaccia 2006-11-13 19:32:57 UTC
Created attachment 76511 [details] [review]
Doesn't add an extra directory with a space
Comment 2 Ross Burton 2006-11-13 20:28:57 UTC
Great.  Can you commit this with a changelog entry?
Comment 3 Adam Petaccia 2006-11-13 21:04:51 UTC
I don't know if this goes in the patch because changelogs get changed, or what, but does this look right?

2006-10-13  Adam Petaccia <adam@tpetaccia.com>
    * src/sj-extractign.c: 
    "none" shouldn't create a directory in Folder hierarchy 
    preference (#374831)

Comment 4 Ross Burton 2006-11-13 21:33:31 UTC
New line after the date and name, and a tab to indent the rest of the lines, but apart from that; just right..
Comment 5 Adam Petaccia 2006-11-13 22:37:26 UTC
2006-10-13  Adam Petaccia <adam@tpetaccia.com>

	* src/sj-extracting.c: 
	"none" shouldn't create a directory in Folder hierarchy 
	preference (#374831)

Sorry, I copied and pasted from a terminal, so those were tabs originally.  This should be exactly what you asked for.
Comment 6 Ross Burton 2006-11-13 22:44:46 UTC
Perfect.  Commit that, thanks!
Comment 7 Ross Burton 2006-11-14 11:19:44 UTC
I found myself looking at SJ code, so I committed this.
Comment 8 Elliot Winkler 2006-12-10 06:32:50 UTC
*** Bug 370297 has been marked as a duplicate of this bug. ***