After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 374760 - [PATCH] last buffer sent by lame may not have (valid) timestamp
[PATCH] last buffer sent by lame may not have (valid) timestamp
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
0.10.4
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-13 16:52 UTC by Mark Nauwelaerts
Modified: 2006-11-14 10:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible patch. (2.02 KB, patch)
2006-11-13 16:55 UTC, Mark Nauwelaerts 		none Details | Review

Description Mark Nauwelaerts 2006-11-13 16:52:17 UTC 
When receiving eos, lame plugin flushes lame encoder buffer.
This data is sent out with minimal decoration of buffer (e.g. no timestamp).
This can be tricky for elements looking at this or even recording a timestamp, e.g. a matroskamux (and as well when it is then read in again some other time).
Comment 1 Mark Nauwelaerts 2006-11-13 16:55:18 UTC 
Created attachment 76496 [details] [review]
Possible patch.

Make lame timestamp flushed eos buffer by some additional timestamp accounting.
Comment 2 Wim Taymans 2006-11-14 10:29:53 UTC 
        * ext/lame/gstlame.c: (gst_lame_sink_event), (gst_lame_chain),
        (gst_lame_change_state):
        * ext/lame/gstlame.h:
        Make lame timestamp flushed eos buffer by some additional timestamp
        accounting. Fixes #374760.