GNOME Bugzilla – Bug 374596
Better alignment for help message in main area
Last modified: 2006-11-14 17:04:03 UTC
The help message in main area ("To add files ....") has two issues: 1. it's not to simple to undertand it's a list of possible actions (due to alignment) 2. it keeps all formatting stuff (\n, <span>, <b>) to translators (l10n guidelines suggest to hide formatting stuff and markups to translators) The attached patch should fix both: 1. adding a GtkAlignment container used to "wrap" the GtkLabel. This allow to keep the message in the middle of the area but aligned to left. 2. splitting the full message and re-building it with g_strconcat. Only relevant stuff are marked for translation. OK to commit?
Created attachment 76464 [details] [review] The proposed patch Note: the "\t* " could be replaced with something using some more sexy character from unicode (for example the FULL DOT, I just have to check its code).
Created attachment 76465 [details] A screenshot of main window with applied patch Note: the message is not placed exacly in the middle of the main area, but it's "visually centered" (i.e. horiz centrered, vertically not). See here[1] http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGWindows/chapter_17_section_4.html#//apple_ref/doc/uid/20000961-BACFHDHE
Forgot to mention: I also applied a little change to order and content of suggested action. For example now the fist suggested action for both add and remove has a reference to toolbar button. Howover I suggest to contact usability list asking for a UI review of this message (as in the old GNOME 2.2/2.4 era).
Thanks a lot for your work. Now I think I'm going to use this patch for 0.5.90 since I don't want to break strings for stable. I'll branch brasero today so you can commit it today or tomorrow.
I forgot, maybe, in the delete actions, we should also mention the drag-and-delete that was added to 0.5.0.
CVS is ready for your patch =). Thanks again.
Commited, with small changes to messages (add files, remove items) and adding the drag-to-remove suggestion. PS it seems that I don't have privileges to change patch status to commited. Could you do it?