GNOME Bugzilla – Bug 374582
Need 'slideshow' button on toolbar
Last modified: 2008-06-17 10:03:19 UTC
General use case: 1. open file browser 2. go to folder with photos 3. double-click to first image, EOG is opens 4. (needed!) push to 'Slideshow' button on toolbar Other information: Can I add/remove buttons in toolbar without modification of application?
(In reply to comment #0) > Can I add/remove buttons in toolbar without modification of application? No, this is not possible, but sounds like an interesting feature. Maybe it's something we would want to do in the experimental branch, eog-ng. Evince already allows users to edit the toolbar.
Marking as gnome-love.
We should definetely have a editable toolbar in EOG. I opened a bug report for better management of this issue (bug #393586). Yes, slideshow would a possible candidate for default toolbar. I think we should first discuss about what we want on EOG's default toolbar. Discussion about this default toolbar can take place in bug #310455.
Created attachment 86453 [details] [review] Adds the fullscreen button to the toolbar Little patch, I think the button looks fine. Are you still considering this bug?
Created attachment 86459 [details] [review] A better approach, this considers the slideshow case too. Following claudio's comments on IRC, here's a new version.
>_< Duh! Wrong bug!
(In reply to comment #4) > Created an attachment (id=86453) [edit] > Adds the fullscreen button to the toolbar > > Little patch, I think the button looks fine. Are you still considering this > bug? There's a patch to make the toolbar editable waiting in bug #393586.
Ok, a Slideshow toolbar item is already available (in the editable toolbar) but there's no icon for it yet. I saw that gthumb and f-spot have their own slideshow icons. I don't know which one is better. Adding Andreas to CC so that we can get some good feedback.
I was looking into fixing this and later stumbled into this bug and bug 435614 I see something weird if I set an named icon for slideshow with for instance the patch below: 1) the icon is correctly displayed on the the toolbar 2) if you drag it off the toolbar in the "edit toolbar window" it becomes a kind of default icon (it looks like a document). 3) Strangely enough this does not happen with the rotate buttons which are also named icons. 4) With a stock icon e.g when I use GTK_STOCK_HOME it works correctly Index: eog-window.c =================================================================== --- eog-window.c (revision 3815) +++ eog-window.c (working copy) @@ -3235,7 +3235,7 @@ }; static const GtkToggleActionEntry toggle_entries_collection[] = { - { "ViewSlideshow", NULL, N_("_Slideshow"), "F5", + { "ViewSlideshow", "object-flip-horizontal", N_("_Slideshow"), "F5", NULL, G_CALLBACK (eog_window_cmd_slideshow), FALSE }, };
There seems to be a slight difference in how the different action-types are created from the action entries. Normal actions set the stock_id property even if it is a named icon, after that it is checked if a named icon with that name exists and if it does the icon_name property is set. Toggle actions (like the slideshow action) only set the stock_id property if it actually is a stock icon. If not the icon_name property is set (without further checks). The toolbar editor currently only reads the stock_id property.
Looks like this was done on purpose: bug 342458. I'll see if I can prepare a workaround.
I committed a workaround. It should work now. See bug 450590 for the libegg bug I opened about it.
The major problems in toolbar editor were solved by Felix already. I've set the slideshow icon to the action and this bug is fixed then. Thanks everyone! 2007-06-26 Lucas Rocha <lucasr@geladinho> * src/eog-window.c: use slideshow icon from gnome-icon-theme for slideshow action. Fixes bug #374582 (Felix Riemann).
That's definitely a strange looking icon (compared to the others). I actually didn't know there was a stock icon for this.
This icon along with all the other icons in the */stock/ directories are not tangofied yet. I just posted a question on the tango mailing list if these icons get tangofied or nuked because they are not in the icon naming spec. I'll keep you up2date about the outcome. Anyway a new icon is needed for slideshow
Icon problems should be reported to gnome-icon-theme. Thanks Jaap for handling this. Send the updates to eog's mailing list.
Created attachment 90761 [details] New icon (screenshot) Well, those stock/ icons in gnome-icon-theme are deprecated¹ and the current icon doesn't look very nice besides the tango icon, so I quickly hacked together my own, see screenshot. [1] http://lists.freedesktop.org/archives/tango-artists/2007-June/001390.html
Created attachment 90762 [details] The icon... Here's the icon, ready to drop into the main tree
Created attachment 90763 [details] [review] and patch to use new icon
Very similar to the icon in f-spot, but based on the presentation icon in gnome-icon-theme.
Micheal, is it possible for you to create other sizes too?
I just committed a touched up version of that icon by Andreas Nilsson.