After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 374582 - Need 'slideshow' button on toolbar
Need 'slideshow' button on toolbar
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
git master
Other All
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on: 310455 393586
Blocks:
 
 
Reported: 2006-11-13 07:41 UTC by Alexander Sashnov
Modified: 2008-06-17 10:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Adds the fullscreen button to the toolbar (429 bytes, patch)
2007-04-16 21:02 UTC, Diego Escalante Urrelo (not reading bugmail)
none Details | Review
A better approach, this considers the slideshow case too. (765 bytes, patch)
2007-04-16 22:39 UTC, Diego Escalante Urrelo (not reading bugmail)
rejected Details | Review
New icon (screenshot) (26.51 KB, image/png)
2007-06-27 16:51 UTC, Michael Monreal
  Details
The icon... (4.71 KB, application/x-gzip)
2007-06-27 16:52 UTC, Michael Monreal
  Details
and patch to use new icon (928 bytes, patch)
2007-06-27 16:53 UTC, Michael Monreal
none Details | Review

Description Alexander Sashnov 2006-11-13 07:41:47 UTC
General use case:
1. open file browser
2. go to folder with photos
3. double-click to first image, EOG is opens
4. (needed!) push to 'Slideshow' button on toolbar

Other information:
Can I add/remove buttons in toolbar without modification of application?
Comment 1 Claudio Saavedra 2006-11-13 15:18:52 UTC
(In reply to comment #0)
> Can I add/remove buttons in toolbar without modification of application?

No, this is not possible, but sounds like an interesting feature. Maybe it's something we would want to do in the experimental branch, eog-ng. Evince already allows users to edit the toolbar.



Comment 2 Claudio Saavedra 2007-01-05 23:52:08 UTC
Marking as gnome-love.
Comment 3 Lucas Rocha 2007-01-06 17:00:23 UTC
We should definetely have a editable toolbar in EOG. I opened a bug report for better management of this issue (bug #393586).

Yes, slideshow would a possible candidate for default toolbar.

I think we should first discuss about what we want on EOG's default toolbar. Discussion about this default toolbar can take place in bug #310455.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2007-04-16 21:02:23 UTC
Created attachment 86453 [details] [review]
Adds the fullscreen button to the toolbar

Little patch, I think the button looks fine. Are you still considering this bug?
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2007-04-16 22:39:02 UTC
Created attachment 86459 [details] [review]
A better approach, this considers the slideshow case too.

Following claudio's comments on IRC, here's a new version.
Comment 6 Diego Escalante Urrelo (not reading bugmail) 2007-04-16 22:40:59 UTC
>_< Duh! Wrong bug!
Comment 7 Claudio Saavedra 2007-04-20 21:59:11 UTC
(In reply to comment #4)
> Created an attachment (id=86453) [edit]
> Adds the fullscreen button to the toolbar
> 
> Little patch, I think the button looks fine. Are you still considering this
> bug?

There's a patch to make the toolbar editable waiting in bug #393586.

Comment 8 Lucas Rocha 2007-04-29 20:29:17 UTC
Ok, a Slideshow toolbar item is already available (in the editable toolbar) but there's no icon for it yet. I saw that gthumb and f-spot have their own slideshow icons. I don't know which one is better. Adding Andreas to CC so that we can get some good feedback.
Comment 9 Jaap A. Haitsma 2007-06-17 17:25:40 UTC
I was looking into fixing this and later stumbled into this bug and bug 435614

I see something weird if I set an named icon for slideshow with for instance the patch below:

1) the icon is correctly displayed on the the toolbar
2) if you drag it off the toolbar in the "edit toolbar window" it becomes a kind of default icon (it looks like a document). 
3) Strangely enough this does not happen with the rotate buttons which are also named icons. 
4) With a stock icon e.g when I use GTK_STOCK_HOME it works correctly





Index: eog-window.c
===================================================================
--- eog-window.c        (revision 3815)
+++ eog-window.c        (working copy)
@@ -3235,7 +3235,7 @@
 };
 
 static const GtkToggleActionEntry toggle_entries_collection[] = {
-       { "ViewSlideshow", NULL, N_("_Slideshow"), "F5", 
+       { "ViewSlideshow", "object-flip-horizontal", N_("_Slideshow"), "F5", 
          NULL, 
          G_CALLBACK (eog_window_cmd_slideshow), FALSE },
 };


Comment 10 Felix Riemann 2007-06-23 12:09:57 UTC
There seems to be a slight difference in how the different action-types are created from the action entries.

Normal actions set the stock_id property even if it is a named icon, after that it is checked if a named icon with that name exists and if it does the icon_name property is set.

Toggle actions (like the slideshow action) only set the stock_id property if it actually is a stock icon. If not the icon_name property is set (without further checks).

The toolbar editor currently only reads the stock_id property.
Comment 11 Felix Riemann 2007-06-24 10:40:18 UTC
Looks like this was done on purpose: bug 342458.

I'll see if I can prepare a workaround.
Comment 12 Felix Riemann 2007-06-24 11:41:51 UTC
I committed a workaround. It should work now.

See bug 450590 for the libegg bug I opened about it. 
Comment 13 Lucas Rocha 2007-06-26 20:22:12 UTC
The major problems in toolbar editor were solved by Felix already. I've set the slideshow icon to the action and this bug is fixed then. Thanks everyone!

2007-06-26  Lucas Rocha  <lucasr@geladinho>

        * src/eog-window.c: use slideshow icon from gnome-icon-theme for
        slideshow action. Fixes bug #374582 (Felix Riemann).
Comment 14 Felix Riemann 2007-06-26 21:17:01 UTC
That's definitely a strange looking icon (compared to the others).

I actually didn't know there was a stock icon for this.
Comment 15 Jaap A. Haitsma 2007-06-26 21:23:06 UTC
This icon along with all the other icons in the */stock/ directories are not tangofied yet. I just posted a question on the tango mailing list if these icons get tangofied or nuked because they are not in the icon naming spec.

I'll keep you up2date about the outcome. Anyway a new icon is needed for slideshow
Comment 16 Lucas Rocha 2007-06-27 07:39:24 UTC
Icon problems should be reported to gnome-icon-theme. Thanks Jaap for handling this. Send the updates to eog's mailing list.
Comment 17 Michael Monreal 2007-06-27 16:51:51 UTC
Created attachment 90761 [details]
New icon (screenshot)

Well, those stock/ icons in gnome-icon-theme are deprecated¹ and the current icon doesn't look very nice besides the tango icon, so I quickly hacked together my own, see screenshot.

[1] http://lists.freedesktop.org/archives/tango-artists/2007-June/001390.html
Comment 18 Michael Monreal 2007-06-27 16:52:43 UTC
Created attachment 90762 [details]
The icon...

Here's the icon, ready to drop into the main tree
Comment 19 Michael Monreal 2007-06-27 16:53:24 UTC
Created attachment 90763 [details] [review]
and patch to use new icon
Comment 20 Michael Monreal 2007-06-27 16:54:42 UTC
Very similar to the icon in f-spot, but based on the presentation icon in gnome-icon-theme.
Comment 21 Jones Lee 2008-05-31 23:17:24 UTC
Micheal, is it possible for you to create other sizes too?
Comment 22 Felix Riemann 2008-06-17 10:03:19 UTC
I just committed a touched up version of that icon by Andreas Nilsson.