After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 373863 - [PATCH] Evince should use the "object-rotate-{left,right}" icons
[PATCH] Evince should use the "object-rotate-{left,right}" icons
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 339480 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-11-11 14:43 UTC by Claudio Saavedra
Modified: 2006-11-11 19:23 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
patch (1.02 KB, patch)
2006-11-11 14:45 UTC, Claudio Saavedra
committed Details | Review

Description Claudio Saavedra 2006-11-11 14:43:39 UTC
Current gnome-icon-theme includes the "object-rotate-{left,right}" icons, that were added to the Icon Naming Spec. Evince may use them for the "EditRotateLeft" and "EditRotateRight" actions.

A patch for this follows.

[this patch was created during a 'live hacking' session in Encuentro Linux Chile, and there are about 200 chilean GNOME lovers watching. If you don't apply it, I will be ridiculized :-) ]
Comment 1 Claudio Saavedra 2006-11-11 14:45:03 UTC
Created attachment 76390 [details] [review]
patch
Comment 2 Carlos Garcia Campos 2006-11-11 14:50:12 UTC
hehe, please commit it, claudio :-)
Comment 3 Claudio Saavedra 2006-11-11 14:56:12 UTC
Thanks Carlos, you are my hero :-)

Committed to HEAD:

2006-11-11  Claudio Saavedra  <csaavedra@alumnos.utalca.cl>

        * shell/ev-window.c: Use "object-rotate-{left,right}" stock icons. 
        Fixes bug #373863.
Comment 4 Nickolay V. Shmyrev 2006-11-11 19:23:47 UTC
*** Bug 339480 has been marked as a duplicate of this bug. ***