After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 372760 - small cruft in ephy-notebook.c (easy)
small cruft in ephy-notebook.c (easy)
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Tabs
unspecified
Other All
: Normal trivial
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2006-11-09 01:06 UTC by Allison Karlitskaya (desrt)
Modified: 2006-11-12 13:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Allison Karlitskaya (desrt) 2006-11-09 01:06:04 UTC 
build_tab_label() in ephy-notebook.c:

        gtk_button_set_relief (GTK_BUTTON (close_button),
                               GTK_RELIEF_NONE);
        /* don't allow focus on the close button */
        gtk_button_set_focus_on_click (GTK_BUTTON (close_button), FALSE);
        gtk_button_set_relief (GTK_BUTTON (close_button), GTK_RELIEF_NONE);

one of those set_relief can probably go.
Comment 1 Allison Karlitskaya (desrt) 2006-11-09 01:07:41 UTC 
while you're at it, this is a few lines down:

        gtk_rc_style_unref (rcstyle),


obviously should be a ; instead of ,
Comment 2 Christian Persch 2006-11-09 12:32:55 UTC 
Feel free to commit the removal of the 2nd _set_relief. The ';' issue was fixed on HEAD already.
Comment 3 Allison Karlitskaya (desrt) 2006-11-12 13:35:25 UTC 
2006-11-12  Ryan Lortie  <desrt@desrt.ca>

        * src/ephy-notebook.c (build_tab_label): Remove redundant
        gtk_button_set_relief call.  Fixes bug #372760.