After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 370990 - Too much space after list items containing links
Too much space after list items containing links
Status: RESOLVED FIXED
Product: website
Classification: Infrastructure
Component: wiki.gnome.org
current
Other Linux
: Normal normal
: ---
Assigned To: Wiki maintainers
Wiki maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-05 12:14 UTC by Joachim Noreiko
Modified: 2008-07-15 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Joachim Noreiko 2006-11-05 12:14:23 UTC
See http://live.gnome.org/CVSRepository for an example.
The spacing in the list looks wrong, and it's each item that contains a link that has too much margin or padding below it.
Comment 1 Joachim Noreiko 2006-11-05 13:57:07 UTC
This is a parser problem rather than CSS:

List elements that contain a link produce a P inside the LI; the others don't.
Comment 2 Dan Winship 2007-12-04 03:28:49 UTC
This annoys me. Is the wiki source/config in SVN somewhere so I can poke at it?
Comment 3 Thilo 2007-12-04 10:21:16 UTC
Please take the time and try to identify the bug here: http://moinmo.in/MoinMoinBugs


And if you think it doesnt exist create a new issue. You could also test if it still exists here: http://moinmo.in/WikiSandBox

MoinMoin 1.6 will be released soon. I dont think it makes sense to start hacking the code in the local version. If there is an accepted patch, maybe, but if not we might not be able to patch in the future. Anybody who wants can download and install a MoinMoin and look at the code: http://moinmo.in/
Comment 4 Dan Winship 2007-12-04 15:54:45 UTC
The problem doesn't exist in http://moinmo.in/WikiSandBox, but I can't find
it in the bugs list. I guess I'll survive until 1.6 comes out. :)
Comment 5 Dan Winship 2008-02-09 21:00:10 UTC
So this is not fixed in 1.6, and is seemingly on purpose.

The offending code is in MoinMoin/parser/text_moin_wiki.py. For some reason, it imagines that it needs to add extra paragraphs in various situations, which are conveniently identified by obscure meaningless numbers. There are the "line862" paragraphs, the "line867" paragraphs,the "line874" paragraphs, and the ever-popular "line891" paragraphs. (These are the names that get assigned to the CSS class of the paragraphs in question. Since they appear in that order in text_moin_wiki.py, a handful of lines apart each, I'm guessing that the numbers used to refer to line numbers of that source file, though they don't any longer.)

Anyway, it turns out that the reason http://moinmo.in/ *appears* to not have the same problem live.gnome.org does is that they added a CSS rule to effectively undo it:

  li p { margin: 0 }

(Yay Firebug, Boo MoinMoin)

"display: inline" would probably be a better rule if we want to copy this.

Which we do. :)
Comment 6 Thilo 2008-02-09 23:08:14 UTC
Ok, if you want to hack on MoinMoin to find the issue:

http://moinmo.in/MoinDev/MercurialGuide

Did you add a bug in MoinMoin also? If not that would be good, so we can track it. Your help is appreciated.
Comment 7 Thilo 2008-06-19 21:31:04 UTC
fixed in 1.6. no further comments from reporter.
Comment 8 Dan Winship 2008-06-20 11:27:25 UTC
Um, this is NOT fixed in 1.6, as described in comment #5. The current best "fix" is to add:

  li p { margin: 0 }

to our css, just like http://moinmo.in/ does
Comment 9 Joachim Noreiko 2008-06-20 11:32:15 UTC
> So this is not fixed in 1.6, and is seemingly on purpose.

I can't think of why you'd want to do that.

Reopening in light of comment #8