GNOME Bugzilla – Bug 370772
Fails to add podcasts that are unavailable
Last modified: 2008-11-15 08:45:03 UTC
This bug was added to the Debian BTS. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=374855 "I'd like to subscribe to Staccato http://staccatomusic.org/podcast/ Unfortunately, my employer blocks this web site and returns a 403 Forbidden error when I try to contact it. As a result, it displays a dialog that contains the following text: Error in podcast There was a problem adding this podcast. Please verify the URL: http://staccatomusic.org/podcast/ [Close] I'd prefer that it add the feed and, when I get home and the URL is accessible, add the rest of the information about it."
I'm not sure what would be best to do here, as we can't tell the difference between a transient and permanent error for things like this. Perhaps an "add anyway" button?
(In reply to comment #1) > I'm not sure what would be best to do here, as we can't tell the difference > between a transient and permanent error for things like this. Perhaps an "add > anyway" button? As the submitter of the upstream report, I'd be happy with this solution. Thanks for looking at the issue.
Created attachment 76910 [details] [review] patch Patch that implements the above
Looks sensible enough. In the case where we don't get a title for the feed so we use the URL instead, it looks like the title won't ever be set correctly. Perhaps we should update podcast feed properties in rb_podcast_manager_insert_feed if the feed entry already exists?
It also displays the error message if it fails to update an existing feed, which isn't great.
This patch is included in the latest revision of the patch on bug 352493, since they're dealing with the same thing. With the updated patch, the error message+question is only displayed for new feeds. For existing feeds, the error is displayed (with no question) if the user manually requested the update.
In case of error when adding a podcast, there is now a dialog box asking if the podcast should be kept anyway. So this bug is fixed, please close it :-)