After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 369550 - [docs] Use gnome-doc-utils for the user manual
[docs] Use gnome-doc-utils for the user manual
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: glchess
unspecified
Other Linux
: Immediate critical
: ---
Assigned To: Danilo Segan
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-02 18:02 UTC by Joachim Noreiko
Modified: 2006-12-27 20:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-doc-utils patch (3.57 KB, patch)
2006-12-09 20:04 UTC, Andreas Røsdal
needs-work Details | Review
Use g-d-u for glchess documentation (5.67 KB, patch)
2006-12-25 12:40 UTC, Danilo Segan
committed Details | Review

Description Joachim Noreiko 2006-11-02 18:02:53 UTC
To help the docs team work with the user guide, please set up the manual with
gnome-doc-utils.
There is currently no content, so you might as well start from scratch rather than migrate.
Comment 1 Jason Clinton 2006-11-03 03:37:29 UTC

*** This bug has been marked as a duplicate of 369538 ***
Comment 2 Joachim Noreiko 2006-11-03 07:45:20 UTC
This one's about glchess, and bug 369538 is for Sudoku.
Comment 3 Joachim Noreiko 2006-11-13 17:43:30 UTC
Could you maybe unduplicate this?

For Sudoko, as there's already a manual, it's a 'would be nice'.
For GLChess, no work can be done on the manual until this is done.
Comment 4 Andreas Røsdal 2006-11-18 19:06:04 UTC
Would it be possible to get some help from the GDP to use gnome-doc-utils?

Since glChess does not have any existing documentation, it would be possible to use some kind of template for new projects starting from scratch with gnome-doc-utils.

Yes, I have read http://live.gnome.org/GnomeDocUtilsMigration
Does it contain all steps required for *new* projects?
Comment 5 Joachim Noreiko 2006-11-22 17:48:30 UTC
I've mentioned this to Don Scorgie on IRC, so he should be along soon. :)

I've just added a template for an application manual to gnome-doc-utils,  data/templates/gnome-app-template.xml.
Comment 6 Joachim Noreiko 2006-11-25 18:06:04 UTC
Don has added these instructions to the wiki:
http://live.gnome.org/GnomeDocUtilsCreateNew
Comment 7 Andreas Røsdal 2006-12-09 20:02:53 UTC
I'm not able to migrate glchess to gnome-doc-utils.
I get this error message:

make[1]: Circular C/glchess <- C/glchess dependency dropped.
make[1]: *** No rule to make target `.xml', needed by `C/glchess'.  Stop.


Could I get some help migrating glchess to gnome-doc-utils?
Comment 8 Andreas Røsdal 2006-12-09 20:04:59 UTC
Created attachment 78048 [details] [review]
gnome-doc-utils patch

Here's the patch I tried so far, which failed miserably.
Comment 9 Danilo Segan 2006-12-12 06:16:13 UTC
Try adding 'help/C/glchess.xml' first.
Comment 10 Don Scorgie 2006-12-12 11:12:28 UTC
Couple of questions / comments on the patch:

* You seem to be missing help/glchess.omf.in (although, this is probably due to CVS stupidity rather than anything else)

* No --disable-scrollkeeper in DISTCHECK_CONFIGURE_FLAGS in the top-level Makefile.am (minor issue)

* You're glchess.xml in CVS is missing some fields required to generate the omf.  See
http://live.gnome.org/GnomeDocUtilsMigrationHowTo
Step 4 for a list of fields that are needed (also look into other manuals for where / how to add them)

I'm not sure exactly why you're getting circular dependancies though.  Possibly because of the omf issue, but I don't think so.  I'll have a look through soon.
Comment 11 Andreas Røsdal 2006-12-16 13:06:39 UTC
I have tried all suggestions from Don.

So unless someone submits a patch for gnome-games to use gnome-doc-utils, it will not happen.
Comment 12 Andreas Røsdal 2006-12-19 18:29:11 UTC
Still no luck with migrating to gnome-doc-utils.

Perhaps it's not possible to migrate to gnome-doc-utils for only one game (glchess), when the existing games still use the old setup.
Comment 13 Danilo Segan 2006-12-25 12:40:30 UTC
Created attachment 78874 [details] [review]
Use g-d-u for glchess documentation

It sure is.  I've made use of your patch and created a change which makes it work for me: if nobody complains, I'll commit it.
Comment 14 Andreas Røsdal 2006-12-25 16:03:56 UTC
Thanks for making gnome-doc-utils work with glChess, you can commit the patch if you are confident that it is correct and that gnome-games passes the 'make distcheck' tests.

If you are interested in helping with migrating the rest of gnome-games to g-d-u, that would also be very much appreciated.
Comment 15 Joachim Noreiko 2006-12-26 13:09:26 UTC
Thanks Danilo :)
What did you do differently, and did the instructions on http://live.gnome.org/GnomeDocUtilsCreateNew miss this?
Comment 16 Danilo Segan 2006-12-26 14:58:28 UTC
The important thing was "xmllint --valid glchess/help/C/glchess.xml" which showed me that XML file was completely broken (which is why "make distcheck" didn't pass even with the above patch).

I don't think there was any other difference, I just added missing bits from Andreas' last patch.

Committed my last patch along with fixes for glchess.xml.
Comment 17 Andreas Røsdal 2006-12-26 18:08:14 UTC
Danilo, now I get the following error message when running ./autogen.sh on gnome-games, Could you please correct this error as soon as possible?

Running intltoolize...
Running aclocal-1.9...
Running autoconf...
Running autoheader...
Running automake-1.9...
cp: cannot stat `INSTALL': No such file or directory
automake-1.9: cannot open < gnome-doc-utils.make: No such file or directory

Comment 18 Danilo Segan 2006-12-26 18:22:07 UTC
Andreas, what version of gnome-autogen.sh (from gnome-common module in Gnome CVS) do you have? And what version of gnome-doc-utils?
Comment 19 Danilo Segan 2006-12-26 18:23:17 UTC
IOW, gnome-autogen.sh should run gnome-doc-prepare for you, which should copy gnome-doc-utils.make over.
Comment 20 Danilo Segan 2006-12-26 18:30:26 UTC
Oh boy, with so much branch changes and going left and right, configure.in changes ended up not being committed.  Hopefully fixed now.
Comment 21 Andreas Røsdal 2006-12-26 19:10:28 UTC
Yes, it is fixed now. Thanks for the quick fix!
Comment 22 Andreas Røsdal 2006-12-27 09:04:18 UTC
Now I get another error when running 'make install' in the glchess directory:


/bin/sh ../../mkinstalldirs /usr/local/share/gnome/help/glchess/C
/usr/bin/install -c -m 644 C/legal.xml /usr/local/share/gnome/help/glchess/C/legal.xml
/usr/bin/install -c -m 644 C/glchess.xml /usr/local/share/gnome/help/glchess/C/glchess.xml
/bin/sh ../../mkinstalldirs /usr/local/share/omf/glchess
/usr/bin/install -c -m 644 glchess-C.omf /usr/local/share/omf/glchess/glchess-C.omf
/usr/bin/install: cannot stat `glchess-C.omf': No such file or directory
Comment 23 Andreas Røsdal 2006-12-27 09:19:30 UTC
This is using version:

gnome-doc-prepare (GNU gnome-doc-utils) 0.8.0
Comment 24 Andreas Røsdal 2006-12-27 09:34:23 UTC
This has now been fixed in CVS, by adding some missing XML elements to the docs.
Comment 25 Andreas Røsdal 2006-12-27 10:31:05 UTC
Here's another compilation error when running 'make distcheck':
Danilo, could you please try running 'make distcheck' again?



mkdir -p -- /home/rosdal/gnome/gnome-games/gnome-games-2.17.4.1/_inst/share/omf/glchess
/usr/bin/install -c -m 644 glchess-C.omf /home/rosdal/gnome/gnome-games/gnome-games-2.17.4.1/_inst/share/omf/glchess/glchess-C.omf
scrollkeeper-update -p /var/lib/scrollkeeper -o /home/rosdal/gnome/gnome-games/gnome-games-2.17.4.1/_inst/share/omf/glchess
/var/lib/scrollkeeper/scrollkeeper_docs: Ikke tilgang
make[4]: *** [install-doc-omf] Error 1
make[4]: Leaving directory `/home/rosdal/gnome/gnome-games/gnome-games-2.17.4.1/_build/glchess/help'
make[3]: *** [install-am] Error 2
make[3]: Leaving directory `/home/rosdal/gnome/gnome-games/gnome-games-2.17.4.1/_build/glchess/help'
make[2]: *** [install-recursive] Error 1
make[2]: Leaving directory `/home/rosdal/gnome/gnome-games/gnome-games-2.17.4.1/_build/glchess'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/rosdal/gnome/gnome-games/gnome-games-2.17.4.1/_build'
Comment 26 Andreas Røsdal 2006-12-27 19:03:50 UTC
Running 'make distcheck' as root solves the problem.
If I recall correctly, distcheck didn't require root access before this patch, though...
Comment 27 Danilo Segan 2006-12-27 20:04:22 UTC
Andreas, this is a problem with scrollkeeper: see bug #354357 for details.

Now, I am not sure we need to test omf file installation in distcheck. Shaun?