After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 369539 - [wavpackenc] More sensible values for GstEnums, don't send no-more-pads twice, add new compression modes
[wavpackenc] More sensible values for GstEnums, don't send no-more-pads twice...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.4
Assigned To: Tim-Philipp Müller
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-11-02 17:46 UTC by Sebastian Dröge (slomo)
Modified: 2006-11-02 20:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wavpackenc.diff (3.49 KB, patch)
2006-11-02 17:47 UTC, Sebastian Dröge (slomo)
committed Details | Review
configure.ac.diff (745 bytes, patch)
2006-11-02 17:47 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2006-11-02 17:46:42 UTC
Hi,
the attached patch changes the GstEnum values to more sensible strings, adds the very fast and very high mode in the enums (very fast is not yet supported but will be in the future, very high is supported in latest SVN for which we have WAVPACK_OLD_API set).

Also the no-more-pads message is not sent twice now when a correction file should be created.

The second patch changes the minimal version for which we don't set WAVPACK_OLD_API to 4.40.0 as this is the version as which this will be released. There is no 4.33 and never will.

Bye
Comment 1 Sebastian Dröge (slomo) 2006-11-02 17:47:17 UTC
Created attachment 75866 [details] [review]
wavpackenc.diff
Comment 2 Sebastian Dröge (slomo) 2006-11-02 17:47:41 UTC
Created attachment 75867 [details] [review]
configure.ac.diff
Comment 3 Tim-Philipp Müller 2006-11-02 20:13:36 UTC
Thanks, committed:

  2006-11-02  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Sebastian Dröge <slomo at circular-chaos.org>

        * configure.ac:
        * ext/wavpack/gstwavpackenc.c: (gst_wavpack_enc_mode_get_type),
        (gst_wavpack_enc_correction_mode_get_type),
        (gst_wavpack_enc_joint_stereo_mode_get_type),
        (gst_wavpack_enc_init), (gst_wavpack_enc_set_wp_config):
          Fix enum nicks; only emit no-more-pads once; add support for very
          fast encoding mode in upcoming 4.40.0 release (#369539).