After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 369482 - [typefind] MPEG system streams get recognized as mp3 files
[typefind] MPEG system streams get recognized as mp3 files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 378397 384112 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-11-02 15:54 UTC by Edward Hervey
Modified: 2006-12-16 18:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for mp3 typefind functions (1.95 KB, patch)
2006-11-02 16:01 UTC, Edward Hervey 		none Details | Review
Different version (1.67 KB, patch)
2006-11-02 16:57 UTC, Edward Hervey 		none Details | Review

Description Edward Hervey 2006-11-02 15:54:15 UTC 
the mp3 typefind is too generous with probability.

One way to do so, would be to decrease the probabilty if we don't find mp3 headers straight away.
Comment 1 Edward Hervey 2006-11-02 16:01:34 UTC 
Created attachment 75849 [details] [review]
Patch for mp3 typefind functions

This proposed patch decreases the probability by the number of times we failed to find a valid header before the valid ones.

Seems to work nicely on a large collection of mp3/mpeg/other files
Comment 2 Edward Hervey 2006-11-02 16:57:42 UTC 
Created attachment 75862 [details] [review]
Different version

Instead of trying to apply some kind of logic, this patch just decreases the probability by a fixed value if we don't find a valid mp3 header at the start.
Comment 3 Edward Hervey 2006-11-02 17:27:48 UTC 
2006-11-02  Edward Hervey  <edward@fluendo.com>

	* gst/typefind/gsttypefindfunctions.c: (mp3_type_find_at_offset):
	Lower the probability of mp3 typefinding functions if we don't find a
	valid mp3 header at the start of the file.
	Closes #369482
Comment 4 Tim-Philipp Müller 2006-12-16 11:01:51 UTC 
*** Bug 384112 has been marked as a duplicate of this bug. ***
Comment 5 Tim-Philipp Müller 2006-12-16 18:45:42 UTC 
*** Bug 378397 has been marked as a duplicate of this bug. ***