After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 368626 - Orca accessing tool tips from gnome-panel causes gnome-panel to crash
Orca accessing tool tips from gnome-panel causes gnome-panel to crash
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.17.x
Other All
: Normal normal
: 2.20.0
Assigned To: Lynn Monsanto
Orca Maintainers
Depends on: 368625
Blocks: 368640
 
 
Reported: 2006-11-01 00:23 UTC by Willie Walker
Modified: 2008-07-22 19:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to ignore all events from tool tips to work around the real cause of the problem (1.84 KB, patch)
2006-11-01 00:41 UTC, Willie Walker
committed Details | Review
first cut at presenting gnome-panel applet tooltips (7.37 KB, text/plain)
2007-03-29 00:36 UTC, Lynn Monsanto
  Details
fixed braino calculating current and minimum GTK version (7.69 KB, text/plain)
2007-03-29 03:23 UTC, Lynn Monsanto
  Details
Fixes problem (2.78 KB, patch)
2007-04-02 20:51 UTC, Lynn Monsanto
needs-work Details | Review
new file that was omitted from patch because I didn't do a "svn add" before generating the patch diffs (3.02 KB, text/plain)
2007-04-02 20:52 UTC, Lynn Monsanto
  Details
Additional fix (2.05 KB, patch)
2007-04-03 16:29 UTC, Lynn Monsanto
none Details | Review

Description Willie Walker 2006-11-01 00:23:06 UTC
See the blocking bug for more info.
Comment 1 Willie Walker 2006-11-01 00:41:16 UTC
Created attachment 75746 [details] [review]
Patch to ignore all events from tool tips to work around the real cause of the problem

This merely ignores all tool tip events.  The real problem seems to lie elsewhere (gail, gtk?), but we need to work around this problem until the bug is fixed.
Comment 2 Willie Walker 2007-02-26 20:37:08 UTC
If there is a way to determine the revision level of the offending version of atk that had this problem, we might be able to if/else the decision about whether to pay attention to or ignore the events.  This might come in the form of looking at the toolkit info of the app of the event source.  Maybe, but querying for that info might also cause the crash.
Comment 3 Willie Walker 2007-03-27 18:27:16 UTC
(In reply to comment #2)
> If there is a way to determine the revision level of the offending version of
> atk that had this problem, we might be able to if/else the decision about
> whether to pay attention to or ignore the events.  This might come in the form
> of looking at the toolkit info of the app of the event source.  Maybe, but
> querying for that info might also cause the crash.

In python, the following seems to give the gtk version:

import gtk
gtk.gtk_version

The current version on Ubuntu Feisty (GNOME 2.18) is:  (2, 10, 11)

So...as a possible solution:

1) Change line in focus_tracking_presenter.py from:
        if event.source.role == rolenames.ROLE_TOOL_TIP:
    to:
        if settings.ignoreTooltipEvents and (event.source.role == rolenames.ROLE_TOOL_TIP):

2) Make the default value of settings.ignoreTooltipEvents be based upon gtk.gtk_version.
Comment 4 Lynn Monsanto 2007-03-29 00:36:41 UTC
Created attachment 85491 [details]
first cut at presenting gnome-panel applet tooltips

gnome-panel appets fire a state-changed:showing event when the tooltip is popped up. However, event source is always the first gnome-panel applet that popped up. It's not just the name and description that's cached, it appears to be the applet accessible.

I temporarily turned off bounds-changed listening for the gnome-power-manager to reduce the flood of events.
Comment 5 Lynn Monsanto 2007-03-29 03:23:43 UTC
Created attachment 85498 [details]
fixed braino calculating current and minimum GTK version
Comment 6 Lynn Monsanto 2007-04-02 20:51:06 UTC
Created attachment 85723 [details] [review]
Fixes problem

This patch appears to fix the problem with the exception of a few applets like the gnome-power-manager and network-applet that (probably) need to be treated as special cases:
Comment 7 Lynn Monsanto 2007-04-02 20:52:59 UTC
Created attachment 85724 [details]
new file that was omitted from patch because I didn't do a "svn add" before generating the patch diffs

New file: src/orca/scripts/gnome-panel.py
Comment 8 Lynn Monsanto 2007-04-03 16:29:02 UTC
Created attachment 85772 [details] [review]
Additional fix

2007-04-03  Lynn Monsanto <lynn.monsanto@sun.com>

        * src/orca/orca.py, src/orca/settings.py: Additional fix for 
        Bug 368626 - [blocked] Orca accessing tool tips from gnome-panel 
        causes gnome-panel to crash.

        Moved setting of settings.presentTooltips from orca.py to
        settings.py. This makes it possible for users to override
        the setting.
Comment 9 Willie Walker 2007-04-04 15:16:48 UTC
The underlying bug for this has been fixed for GNOME 2.18, so I'm removing the '[blocked]' prefix.  Lynn - if the patches in question have been committed, please mark them as so.  In addition, it seems as though this particular bug (the crash) has been fixed, so I think you can close this bug as FIXED.  Thanks!
Comment 10 Lynn Monsanto 2007-04-05 18:02:55 UTC
The patches have been committed. Closing the bug as fixed.