After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 368273 - Using the remove signal on multifdsink is not threadsafe
Using the remove signal on multifdsink is not threadsafe
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-31 13:01 UTC by Michael Smith
Modified: 2006-10-31 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for threadsafety (5.14 KB, patch)
2006-10-31 13:02 UTC, Michael Smith 		none Details | Review
Updated patch handling threadsafety correctly in a few more places (7.68 KB, patch)
2006-10-31 13:55 UTC, Michael Smith 		committed Details | Review

Description Michael Smith 2006-10-31 13:01:46 UTC 
Calling remove on multifdsink can cause crashes in a variety of ways.

This patch (to be attached) makes a few paths safer (e.g. so that calling get-stats on an fd that isn't in the sink won't segfault), and also makes iteration over the clients list threadsafe.
Comment 1 Michael Smith 2006-10-31 13:02:23 UTC 
Created attachment 75720 [details] [review]
Patch for threadsafety
Comment 2 Michael Smith 2006-10-31 13:04:03 UTC 
On second thought, there's a bunch more places where this would need fixing. I'll do that after lunch.
Comment 3 Michael Smith 2006-10-31 13:55:55 UTC 
Created attachment 75723 [details] [review]
Updated patch handling threadsafety correctly in a few more places
Comment 4 Michael Smith 2006-10-31 14:19:47 UTC 
Committed, fixed.