After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 367827 - make pcrecpp dependency optionnal
make pcrecpp dependency optionnal
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: lsof
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
: 395142 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-30 18:24 UTC by Benoît Dejean
Modified: 2011-11-11 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (4.15 KB, patch)
2006-12-09 17:44 UTC, Benoît Dejean
committed Details | Review

Description Benoît Dejean 2006-10-30 18:24:13 UTC
I need someone to craft system-monitor/configure.in to automate pcrecpp detection and make this dependency optionnal. It's on CVS HEAD. Please help me with the configure.in and i'll cope with the code. Thanks.
Comment 1 Kjartan Maraas 2006-10-31 16:47:43 UTC
I changed this:

diff -u -p -r1.192 configure.in
--- configure.in        25 Oct 2006 11:16:54 -0000      1.192
+++ configure.in        31 Oct 2006 16:46:07 -0000
@@ -32,7 +32,7 @@ LIBGTOP_REQUIRED=2.14.4
 GTK_REQUIRED=2.8.0
 GNOME_VFS_REQUIRED=2.6.0
 GNOME_ICON_THEME_REQUIRED=2.15.3
-PCRE_REQUIRED=6.7
+PCRE_REQUIRED=6.6

to make it build here. I'm using a Fedora development system and if the bleeding edge of fedora doesn't have a new enough pcre version I guess we shouldn't depend on one unless we really have to. g-s-m built just fine with version 6.6.
Comment 2 Benoît Dejean 2006-11-01 14:08:15 UTC
OK, i've downgraded the dep on 6.6. I used 6.7 because that was my version, but i doesn't use any special feature, so even < 6.6 may work fine.
Comment 3 Adam Dingle 2006-11-19 16:34:40 UTC
FYI, I just built gnome-system-monitor from CVS HEAD on Ubuntu 6.10, which has libpcre3 version 6.4, so I edited configure.in to have PCRE_REQUIRED=6.4.  The build completed without errors and the executable seems to work fine.
Comment 4 Benoît Dejean 2006-12-09 17:44:27 UTC
Created attachment 78038 [details] [review]
proposed patch

I still haven't decided if this is a joke or the GNOME way to have regular expressions for everyone.
Comment 5 Benoît Dejean 2007-01-10 20:24:49 UTC
*** Bug 395142 has been marked as a duplicate of this bug. ***
Comment 6 Benoît Dejean 2007-06-28 07:27:20 UTC
no pcrecpp, no feature
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.