GNOME Bugzilla – Bug 367760
Evolution Mail: The Save / Save All Butt...
Last modified: 2007-11-22 12:31:08 UTC
What were you doing when the application crashed? The Save / Save All Button for attachments in Evolution 2.8.1 does not work as well as it did in previous versions. -It does not remember the directory chosen on previous saves, instead it always defaults to the users home directory. -It overwrites files without prompting. If you save the same file via right-click "Save As..." it asks if you want to overwrite. -File names with certain characters such as # are truncated on save. Again, if you save the same file via right-click "Save As..." the file name is saved correctly. IIRC the previous version of Evolution had none of these problems. Thanks, Dave Croal Distribution: Ubuntu 6.10 (edgy) Gnome Release: 2.16.1 2006-10-02 (Ubuntu) BugBuddy Version: 2.16.0
Can you still reproduce this problem or has it been fixed since?
I checked again and all the problems listed above still exist.
I am now using Evolution 2.9.92 with Ubuntu Feisty and the problem with the Save/Save All button is mostly still there: Fixed: 1. The problem where "it does not remember the directory chosen on previous saves, instead it always defaults to the users home directory" appears to be fixed now. Still broken: 2. Save/Save All overwrites files without prompting. If you save the same file via right-click "Save As..." it asks if you want to overwrite. 3. Attachment file names with certain characters such as # are truncated on save. If an email has several such attachments the first attachment is is saved with a truncated file name and the other attachments are not saved at all. Eg. "Letter of thanks # 1.doc" saves as "Letter of thanks". A new but probably related problem has cropped up in 2.9.92, when an attachment with a file name containing spaces is saved via right-click, Save As... the saved file name contains %20 instead of spaces, making for a very ugly looking file name. Eg. "Letter of thanks # 1.doc" saves as "Letter%20of%20thanks%20%23%201.doc" Thanks, Dave Croal
The problems still exist with Evolution 2.10.0 from Ubuntu Feisty.
Created attachment 93852 [details] [review] proposed eds patch for evolution-data-server; gnome-vfs doesn't like '#' character too, so serve with it as with non-safe character.
Created attachment 93853 [details] [review] proposed evo patch for evolution; also added '#' as non-safe character into em_filename_make_safe and using this function when saving attachments. Removed gnome_vfs_escape_string from e_file_get_save_filesel, it makes a mess there :)
Milan, this is looking good. For the "overwrite without prompting" problem, I think we just need to call gtk_file_chooser_set_do_overwrite_confirmation(). http://developer.gnome.org/doc/API/2.0/gtk/GtkFileChooser.html#gtk-file-chooser-set-do-overwrite-confirmation
It currently asks for overwrite in 2.11.90 (I patched it sometime back). From comment #7, approving it.
eds part committed to trunk. Committed revision 7977. evo part committed to trunk. Committed revision 34042.
*** Bug 495606 has been marked as a duplicate of this bug. ***