After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 366930 - disable-api-atkmm causes pkg-config to break
disable-api-atkmm causes pkg-config to break
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: general
2.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2006-10-29 15:19 UTC by John N. Laliberte
Modified: 2006-11-21 09:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
gtkmm-2.10.2-remove_atk_from_gtk_pc.patch (422 bytes, patch)
2006-10-29 15:20 UTC, John N. Laliberte
none Details | Review
Patch to add/remove atkmm-1.6 from gtkmm-2.4.pc if api-atkmm is wanted at configure time (1.05 KB, patch)
2006-11-18 23:41 UTC, Rémi Cardona
none Details | Review

Description John N. Laliberte 2006-10-29 15:19:36 UTC
As reported here:

http://bugs.gentoo.org/153294

the gtkmm-2.4.pc unconditionally includes atkmm-1.6.

"
pkg-config --libs gtkmm-2.4
Package atkmm-1.6 was not found in the pkg-config search path.
Perhaps you should add the directory containing `atkmm-1.6.pc'
to the PKG_CONFIG_PATH environment variable
Package 'atkmm-1.6', required by 'gtkmm', not found
"

I am not sure if you want gtkmm to require atkmm if you enable it or just have people migrate to using the atkmm pc file instead.

Attached is a patch to remove the unconditional atkmm-1.6 in the gtkmm pc file.
Comment 1 John N. Laliberte 2006-10-29 15:20:34 UTC
Created attachment 75617 [details] [review]
gtkmm-2.10.2-remove_atk_from_gtk_pc.patch
Comment 2 Murray Cumming 2006-10-31 08:48:42 UTC
This should use a variable so that atkmm is required when it is built.
Comment 3 Rémi Cardona 2006-11-18 23:41:49 UTC
Created attachment 76818 [details] [review]
Patch to add/remove atkmm-1.6 from gtkmm-2.4.pc if api-atkmm is wanted at configure time

If atk-spi is enabled then the gtkmm.pc file is identical to the original one. If it's disabled, there's a double space between pangomm-1.4 and gtkmm-2.0 which doesn't seem to bother pkg-config.

Murray, is this what you had in mind?
Comment 4 Murray Cumming 2006-11-21 09:19:17 UTC
Yes, that's great, thanks. Committed to the HEAD and gtkmm-2-8 branches.

Please remember to patch the ChangeLog in future.