After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 366542 - crash with "ignore thread" when no thread selected
crash with "ignore thread" when no thread selected
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other Linux
: Normal major
: 1.0
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2006-10-28 22:28 UTC by Carl Roth
Modified: 2006-10-30 22:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pan session trace (27.45 KB, text/plain)
2006-10-28 22:29 UTC, Carl Roth 		  Details
Proposed patch (715 bytes, patch)
2006-10-29 00:34 UTC, Christophe Lambin 		committed Details | Review

Description Carl Roth 2006-10-28 22:28:03 UTC 
This is for Pan 0.117, on Fedora Core 5 (i386).

When Pan first enters a group, the first thread in the group display is not selected (the outline-box, but not the reverse-video selection).  If I try to ignore the first thread (M-A I) without explicitly selecting it, Pan crashes with a segfault.
Comment 1 Carl Roth 2006-10-28 22:29:58 UTC 
Created attachment 75585 [details]
pan session trace

This is a 'script' session with pan running under gdb.  Pan is invoked with the --debug switch.

The crash happens when I type 'G' to select the first unread group, then 'M-A I' to ignore the first thread in the group.
Comment 2 Christophe Lambin 2006-10-29 00:34:45 UTC 
Created attachment 75587 [details] [review]
Proposed patch

Confirmed. The above patch addresses this problem.

IMO, we should desensitize menu items that don't apply when no article is selected.
Comment 3 Carl Roth 2006-10-29 03:47:54 UTC 
Looks good.  I re-built the RPM and verified corred behavior.

I agree that greying out the invalid menu items would be preferable, but this is good for now.
Comment 4 Charles Kerr 2006-10-30 21:11:10 UTC 
Chris: looks good; please commit.
Comment 5 Christophe Lambin 2006-10-30 22:38:01 UTC 
Committed.