After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 366113 - Configuration breaks under Solaris
Configuration breaks under Solaris
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: build
1.4.x
Other Solaris
: Normal major
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2006-10-28 06:20 UTC by David Sainty
Modified: 2007-04-05 20:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed Patch, made with sed (597 bytes, patch)
2006-10-29 04:58 UTC, Kevin McBride
none Details | Review

Description David Sainty 2006-10-28 06:20:07 UTC
I haven't tested version 1.5.0, but I have checked the code and the bug appears to still be there.

Solaris /bin/sh doesn't support the $PWD variable.  The "configure" script has this code:

if test -z $PWD; then
  PWD=`pwd`
fi

There are two problems:

1. $PWD may be set by a different shell, I.e. the user's own shell.  If you are using an automated build system (E.g. Package Source - http://www.pkgsrc.org/), the chances are that $PWD will be set to some completely different directory, and so the configure will break.

2. The code itself won't work as intended anyway.  test -z expects a parameter, but because $PWD isn't quoted, if $PWD is unset or zero length the test will fail (with an error message), and PWD=`pwd` will never execute.  Quoting $PWD would fix this, but not problem #1.

Probably the best solution is to not use $PWD at all, and unconditionally set something like:

configPWD=`pwd`
Comment 1 Kevin McBride 2006-10-29 04:58:10 UTC
Created attachment 75591 [details] [review]
Proposed Patch, made with sed
Comment 2 Kevin McBride 2006-10-29 05:01:42 UTC
Give my patch a test on your Solaris system, and let us know of the results.  Dimitri or I will mark the bug as confirmed should the patch work.

Kevin -> Dimitri: Make sure the patch doesn't cause problems with your Mac as well, for regression reasons.
Comment 3 David Sainty 2006-10-29 07:20:48 UTC
Hi Kevin,

In the patch,

+$configPWD=`pwd`

... should of course be:

+configPWD=`pwd`

?
Comment 4 Kevin McBride 2006-10-29 13:56:11 UTC
David, did the patch work with your modification to it?
Comment 5 David Sainty 2006-10-29 14:01:30 UTC
I'll be testing it tomorrow.  It worked on NetBSD at home, the Solaris box is a work box.
Comment 6 David Sainty 2006-10-29 23:52:33 UTC
Tests fine on Solaris.  The patch I tested (including modification) can be found here:

http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/devel/doxygen/patches/patch-ai
Comment 7 Dimitri van Heesch 2006-10-30 19:59:25 UTC
Ok, thanks for the patch. I'll include it in the next CVS update.
Comment 8 Dimitri van Heesch 2007-04-05 20:10:09 UTC
This bug was marked "assigned" by me some time ago, which means it should be
fixed in version 1.5.2 and is hereby marked as such. I would kindly request you
to check if this version indeed fixes the problem and reopen the bug report
should you still see the same problem.