After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 365086 - need a way to rescan
need a way to rescan
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: baobab
trunk
Other Linux
: Normal normal
: ---
Assigned To: Fabio Marzocca
gnome-utils Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-25 19:11 UTC by Matthias Clasen
Modified: 2006-10-28 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
implement a refresh button (3.38 KB, patch)
2006-10-25 20:23 UTC, Emmanuele Bassi (:ebassi)
none Details | Review

Description Matthias Clasen 2006-10-25 19:11:37 UTC
that seems to be a big omission. it would make the use case of
scan home directory, look at graphical map to find big garbage,
delete, repeat...
much more convenient.
Comment 1 Paolo Borelli 2006-10-25 19:40:42 UTC
agreed.
Comment 2 Emmanuele Bassi (:ebassi) 2006-10-25 20:14:58 UTC
I'm working on this (as well as bug #365088), will attach a patch shortly.
Comment 3 Emmanuele Bassi (:ebassi) 2006-10-25 20:23:24 UTC
Created attachment 75407 [details] [review]
implement a refresh button

this patch add a refresh button.  the correct key shortcut should be Ctrl+R, but that is already taken by "scan remote folder" so I left it empty.  I think that scan remote folder should have another key shortcut, with a refresh button on the toolbar: users expect to use the same shortcut used by epiphany and nautilus (I know I'm pissed off each time an application *doesn't* use Ctrl+R for refresh).
Comment 4 Paolo Borelli 2006-10-25 20:29:24 UTC
Actually I am not sure that is *so* important to be on the toolbar: honestly I would prefer to just have it in the Fil^H^H^HAnalyzer menu.

As for the shortcut I agree that it should have Ctrl+R, I think we can leave scan remote folder without shortcut since it's not so common (nautilus' connect to server is without shortcut too)
Comment 5 Emmanuele Bassi (:ebassi) 2006-10-25 22:23:40 UTC
having the refresh button in the toolbar makes it more like a nautilus window (in browser mode).  also, the refresh menu item should be inside the 'View' menu.
Comment 6 Paolo Borelli 2006-10-25 22:35:29 UTC
Well, I don't have a strong opinion about having or not having it in the toolbar, but it seems a bit excessive to me: the RFE is more than reasonable but I don't feel like it something used that often to stay in the toolbar. Beside if in the future we monitor changes properly, the need for a refresh button goes away and I'd prefer to avoid the UI churn on somthing as visible as the toolbar. But as I said, if other thinks that it's good to have in the toolbar, I will not complain... Fabio what do you think?

About using the View menu, I do not agree: rescanning is a very similar action to the initial scan. It is slow and can be cancelled with the "stop" menu item that is in the Analyzer menu, so I think it belongs there... or maybe I am just used to see "Revert" in the gedit File menu :)
Comment 7 Matthias Clasen 2006-10-25 22:43:13 UTC
No strong opinion on the toolbar, a menuitem would be fine for me, or maybe
even in the context menu for the individual folders. I do agree that the menuitem
belongs next to the other scan menuitems in the "Analyzer" menu
Comment 8 Fabio Marzocca 2006-10-26 07:07:08 UTC
Agree on the Analyzer Menu. Concerning the toolbar, my opinion is that we can leave it there and just remove when (and if) we provide a better monitor on changes.
Comment 9 Fabio Marzocca 2006-10-26 13:18:45 UTC
Emmanuele,
maybe something's wrong in the glade patch? I can't display the refresh button.
Comment 10 Paolo Borelli 2006-10-28 15:46:27 UTC
I committed a patch based on Emmanuele one that fixes this, adds both the menu item and the toolbar button, properly sets the initial sensitivity and tidies up some conflicting accelerators.