After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 364757 - Faster implementation of imap_update_summary that consumes less bandwidth and memory
Faster implementation of imap_update_summary that consumes less bandwidth and...
Status: RESOLVED OBSOLETE
Product: evolution-data-server
Classification: Platform
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-10-24 17:31 UTC by Philip Van Hoof
Modified: 2007-01-30 01:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implementation (31.92 KB, patch)
2006-10-24 17:33 UTC, Philip Van Hoof 		none Details | Review
Some fixes (32.52 KB, patch)
2006-10-25 22:41 UTC, Philip Van Hoof 		none Details | Review

Description Philip Van Hoof 2006-10-24 17:31:52 UTC 
This is a tracker bug where I will attach a patch for Matthew to reflow into a patch suitable for Evolution's HEAD.
Comment 1 Philip Van Hoof 2006-10-24 17:33:21 UTC 
Created attachment 75319 [details] [review]
Implementation

If something doesn't work or if you need assistance, just ask.

You basically have to remove the camel_summary_folder_dump_mmap API for a non-mmapped version of Camel to work with this.
Comment 2 Philip Van Hoof 2006-10-24 18:17:06 UTC 
Also take a look at Bug #364766 for the mmap patch for Camel.
Comment 3 Philip Van Hoof 2006-10-24 19:52:35 UTC 
The g_free(resp) at 2393 etc should be something like this:

if (type == CAMEL_IMAP_RESPONSE_TAGGED && resp)
		g_free (resp);

Else it might become a double-free in case a cancellation happened while looping was happening.

So only in case the response was a tagged one, free it. Else, leave it as a memory-leak as its status will be unknown.
Comment 4 Philip Van Hoof 2006-10-25 22:41:59 UTC 
Created attachment 75416 [details] [review]
Some fixes