GNOME Bugzilla – Bug 364618
Chinese characters can't be synced between Palm and Evolution
Last modified: 2013-09-13 12:31:52 UTC
Please describe the problem: Chinese characters can't be synced between Palm and Evolution.The words synced from Palm display as garbage codes in Evolution, and the words synced from evolution display as marks "???" in Palm. Steps to reproduce: Connect Palm Treo600 with Sparc machine by USB port. Install NV22 and Gnome Pilot pkgs for USB port in Sparc machine. 1.Write some Chinese words on To Do List in Palm and some different Chinese words on Tasks in Evolution on Solaris platform. 2.Enable synchronization at the EToDo conduit in Pilot Settings. 3.The words synced from Palm display as garbage codes in Evolution, and the words synced from evolution display as marks "???" in Palm. Actual results: The words synced from Palm display as garbage codes in Evolution, and the words synced from evolution display as marks "???" in Palm. Expected results: The word can be synced successfully between Palm and evolution. Does this happen every time? yes/ Other information:
Created attachment 75280 [details] [review] patch for this bug
Created attachment 78893 [details] [review] patch for this bug
Created attachment 79357 [details] [review] application patch It currently works on pilot-link-0.11.8 as well as pilot-link-0.12.x and is based on the patch for gnome-pilot's bug(385443).
Patch looks good. Once patch in bug#285443 gets committed, I will take it in. Thanks, Jerry.
The patch in bug#385443 was committed.
Created attachment 94911 [details] [review] new patch In the evolution 2.11.92 tarball, two functions which called e_pilot_utf8_to_pchar() and e_pilot_utf8_from_pchar() were added. One is e_pilot_local_category_to_remote() for the conversion from an evolution category to a palm category. The other is e_pilot_remote_category_to_local() for the conversion from a palm category to an evolution category. So I remade a patch to adapt the modification in evolution tarball.
Created attachment 106230 [details] [review] patch reworked due to gnome-pilot upgrading to 2.0.16
Created attachment 135650 [details] [review] rework the patch based on the master
I'm not able to test this, but patch looks good, very straightforward, so I say yes, commit it to master. Only make few changes to it: a) use 'gchar' instead of 'char', please b) if your function takes a parameter, then make it 'const gchar *', not 'gchar *', unless the function itself is supposed to change content of that variable. c) do not define the charset as a global variable, make it part of ctx structure If not sure, feel free to update patch here, otherwise commit to master with above changes. Thanks.
Created attachment 148722 [details] [review] Reworked the patch per as your suggestions
Committed the patch to master.