GNOME Bugzilla – Bug 364529
Allow voice styles (e.g., link voice) to be undefined
Last modified: 2007-01-02 21:25:48 UTC
Some users do not want some voice styles, such as the upper case and link voices. As a means to help do this, we should consider allowing these voices styles to not even be defined at all in settings and then behave appropriately (i.e., fallback to the default voice) in the various places where they are used.
This would be very desirable as we would like to have multiple ways of defining how a link is presented in speech.
In playing with this today, the way to make this happen with the current orca implementation is to set the voice to None in user-settings.py. For example, change the following line in user-settings.py from: 'hyperlink' : orca.acss.ACSS({'average-pitch': 2}), to: 'hyperlink' : None, This will tell Orca to use the default voice.
Note, however, that we can't close this bug so easily. We may want to have some better smarts to combine utterances that use the same voice style so that the prosody works out well. This will take a bit of thought since we often want longer pauses to better delineate things. Furthermore, we may also want to refactor the speechgenerator to return [(utterance, acss), (utterance, acss), ...] instead of [utterance, utterance, ...] to allow it to provide finer granularity over the voice style used. For people that don't want different voice styles, using the "None" solution described in the previous comment would continue to work.
Created attachment 76599 [details] [review] Patch to fix the problem. By default, the hyperlink voice will now initially get it's settings from the default voice.
Changes checked into CVS HEAD. Mike could you let me know if this is what you'd like before I close it out? Thanks.
This change seems to work as expected. However, when I removed my .orca directory to test this, my pitch defaulted to 9. As I've never seen this before I didn't know if it was some how an unintended change.
"my pitch defaulted to 9" Do you mean pitch or gain? The three default settings start with: defaultACSS[acss.ACSS.RATE] = 50 defaultACSS[acss.ACSS.GAIN] = 9 defaultACSS[acss.ACSS.AVERAGE_PITCH] = 5
I mean pitch. To test: Delete your .orca directory, start orca, enter the config UI. When you tab to the pitch at least if you are using Dectalk it seems to be set to 9.
Created attachment 76679 [details] [review] Patch to fix the initial bogus pitch value. Twas in the Glade file. Change checked into CVS HEAD.