GNOME Bugzilla – Bug 363801
Provide confirmation when the user presses Insert R/C in Calc
Last modified: 2006-10-22 19:44:18 UTC
Currently, pressing Insert R/Insert C in Calc allows you to set the location of the column/row titles for your worksheet. Pressing it twice quickly clears the location. However, no confirmation is provided when you use these commands. It would be helpful to have confirmation so that you know what has been set/cleared. (Suggested at Boston Orca users group)
Easy to do. This will be in setDynamicColumnHeaders() and setDynamicRowHeaders() in .../src/orca/scripts/StarOffice.py. We will need to speak/braille the new column/row and state that it's been cleared.
Created attachment 75165 [details] [review] Patch to hopefully implement this enhancement.
Changes checked into CVS HEAD. Closed as FIXED.
This is awesome!! Thanks!!! I'm going to toss one thing out there for consideration, however: When you press Insert C, Orca now reports the column containing the dynamic row headers *in terms of a number* (e.g. Column 1, Column 2, etc.). Since Calc labels columns with letters, I'm wondering if it would be possible to report the column using letters instead. Regardless, this is very cool. :-)
I actually spent about thirty minutes yesterday trying to do this. I niavely thought I'd be able to use _getSpeechForColumnHeader() and _getSpeechForRowHeader() but they don't seem to help. Tomorrow, I'll cons up a small routine to turn a column number into a string of letters [A-Z,A[A-Z] and so on...].
Created attachment 75208 [details] [review] Patch to speak the column number as column letter(s).
New changes checked into CVS HEAD.
A minor nit to help our i18n/l10n friends would be to use formatting of strings rather than concatenate them. We don't always do this in Orca (sometimes it's hard to do), but in this case, I think we can do it easily. Something like the following pattern for the various places where this is done: _("Dynamic column header set for row %s") % str(row+1) _("Dynamic row header set for column %s") % self.columnConvert(column+1) Thus, in a locale where ordering of things might be different, the localized string might look like: _("Owray %s is ownay the ynamicday olumncay eaderhay")
Okay. Change checked into CVS HEAD. Thanks.