GNOME Bugzilla – Bug 363665
Use compositing to display the typing break window
Last modified: 2007-02-03 08:13:10 UTC
Would probably be nicer than taking a picture of the whole desktop.
*** Bug 385073 has been marked as a duplicate of this bug. ***
I agree, it would be awesome :)
Created attachment 78251 [details] [review] patch This uses cairo to dim the background and: - Fixes two small bugs in gsd-media-keys-window.c - Converts to G_DEFINE_TYPE - Uses g_type_class_add_private - Grabs the keyboard from a map_event callback to avoid a race - Moves the stop sign image next to "Take a break!" label for two reasons a) it makes more sense there I think b) the variable font size of the clock label made the image move around - Removes some spurious trailing whitespace The composited case works well but I haven't gotten a chance to test the non-composited case yet.
Why the change of Priv -> Private?
- consistency with the rest of the module and GNOME - most people prefer not to abbreviate words if possible - to make copy/paste reuse easier
and so that the DRW_BREAK_WINDOW_GET_PRIVATE macro usage has more symmetry, ie: DrwBreakWindowPrivate *priv = DRW_BREAK_WINDOW_GET_PRIVATE (window);
Alright, I would prefer not to change those things, but since I don't have much time myself for this module, I'm just thankful that someone has, so I won't argue about that :) I've tried the patch in the non-composite case and it works nicely. I don't really like the move of the label, and I haven't seen the problem ever that you described. When does it happen? And is there another way to fix it (for example by tweaking the alignment or the width of the label)? As a side point, usually it's a good idea to not include whitespace changes in patches, it makes reviewing harder. It's also often better to limit the patch to what the bug report is for. I have no say in the media keys part for example.
I've tested the patch with AIGXL and beryl and it works fine for me.
There is a UI freeze in effect now, not sure if that matters for this? If someone wants to ask for permission to break it and commit this, I'm all for it. I just tested it without composite support again and it works nicely.
I think go ahead and ask for the break. Now that it is using transparency it would be good if it matched the new composited volume widget.
(In reply to comment #9) > There is a UI freeze in effect now, not sure if that matters for this? If > someone wants to ask for permission to break it and commit this, I'm all for > it. I just tested it without composite support again and it works nicely. It's not a UI change, it just sucks less at showing you a (fake) transparent window :)
Well, it moves around the labels and icon as well ;)
Hi, I'm sorry that I never got a chance to respond to Richard's comments properly. This came together quickly before the holidays... also sorry if I came across as abrupt. I think this is probably in good enough shape to go in. I'm going to commit this based on the following: * Richard seems fine with it * according to http://live.gnome.org/ReleasePlanning/Freezes we are only in the "slushy ui freeze" and not a hard freeze * this window doesn't seem to be documented with a screenshot * the ui changes are pretty insignificant * it can be considered a bug fix * and it isn't clear that any of us have time to work on this later :)
Thanks! :)