GNOME Bugzilla – Bug 363645
"Labels" with no labels give a huge search bar
Last modified: 2013-09-13 00:55:51 UTC
evolution-2.8.0-7.fc6 I upgraded from evolution-2.0.2 (on RHEL4) to evolution-2.8.0-7.fc6 (on FC6), and the search bar is absolutely huge, as shown in this screenshot.
Created attachment 75077 [details] Screenshot-INBOX - Evolution.png
I also noticed the search text entry isn't taking the whole width available.
funky! reminds me of http://bugzilla.gnome.org/attachment.cgi?id=68223&action=view (bug 346318), though it is probably unrelated. totally wild guess: hadess, does this also happen if you change your gnome wide "symbols below text/only symbols/only text/blah" settings?
(In reply to comment #3) > funky! > reminds me of http://bugzilla.gnome.org/attachment.cgi?id=68223&action=view > (bug 346318), though it is probably unrelated. That reminded me of something. See attached screenshot below. > totally wild guess: hadess, does this also happen if you change your gnome wide > "symbols below text/only symbols/only text/blah" settings? Yep it does.
Created attachment 75083 [details] Screenshot.png The en_GB translation is busted.
On my system: $ gconftool-2 --get /apps/evolution/mail/labels [:#ff0000,:#ff8c00,:#008b00,:#0000ff,:#8b008b] So evolution is trying to translate an empty string, which means it gets the pot file's header as the translation instead of another empty string. run this to replicate on your system: gconftool-2 --set --type list --list-type=string /apps/evolution/mail/labels '[:#ff0000,:#ff8c00,:#008b00,:#0000ff,:#8b008a]' and run evolution with in a translated language (like en_GB, or somesuch). Evolution should check that the string isn't empty before trying to translate it.
I unset the /apps/evolution/mail/labels GConf key, and I'm back with a normal size toolbar. I filed bug 363680 to track the search text entry width problem.
*** Bug 374980 has been marked as a duplicate of this bug. ***
*** Bug 473872 has been marked as a duplicate of this bug. ***
Created attachment 94993 [details] [review] patch
there's much likely a better way to fix this, but hey - i'm not a C coder, and it works for me. :) no idea whether all .po files start with that string - real hackers, go ahead!
Comment on attachment 94993 [details] [review] patch >Index: evolution/mail/mail-config.c >=================================================================== >--- evolution/mail/mail-config.c (Revision 34178) >+++ evolution/mail/mail-config.c (Arbeitskopie) >@@ -176,6 +176,10 @@ > *colour++ = '\0'; > label->tag = g_strdup(label_defaults[num].tag); > label->name = g_strdup (_(buf)); >+ /* Ugly hack to make sure that a string is displayed >+ for empty label names, works around bug 363645: */ >+ if (strncmp (label->name, "Project-Id-Version", 18) == 0) >+ label->name = g_strdup (_("Unnamed")); > label->colour = g_strdup (colour); You're fixing the symptom, not the problem :) The problem is that it's trying to translate an empty string. So: /* Don't translate an empty string */ if (buf == NULL || buf[0] == '\0') label->name = g_strdup (_("Unnamed")); else label->name = label->name = g_strdup (_(buf));
ahhh... i knew some real hackers would always be around. :-)
Created attachment 95023 [details] [review] correct patch correct patch, as described by hadess
note that committing this won't break the string freeze.
Commit to head please.
Committed as revision 34186. This will be available in version 2.12.0. Thanks, Bastien! :)
*** Bug 436956 has been marked as a duplicate of this bug. ***
*** Bug 506545 has been marked as a duplicate of this bug. ***