After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 363607 - xvimagesink xwindow_draw_border() slowness
xvimagesink xwindow_draw_border() slowness
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.11
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-20 08:48 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2006-11-30 22:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
conditionaly draw border (1.37 KB, patch)
2006-10-20 10:39 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
none Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2006-10-20 08:48:27 UTC
if one sets xvimagesink->keep_aspect=TRUE xvimagsink centers the picture in gst_xvimagesink_xvimage_put(). A few lines down it calls gst_xvimagesink_xwindow_draw_borders(). This is causing quite a slowdown in performance for us (just commenting out the _xwindow_draw_borders() call make it much better).

Now the plan is:
* first only call _xwindow_draw_borders() if xvimagesink->keep_aspect==TRUE, otherwise there will be no border anyway.
* next only do the centering and the border-drawing if the sizes have changed.

Finally I belive its up to the ui to paint the background black (or to what ever). So wouldn't it make sense to have a 'draw-border' property (default TRUE), so that if apps handle the sizing, they can paint the border?
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2006-10-20 10:38:18 UTC
maybe its enough to draw the border on the first image and ater expose events (see patch)
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2006-10-20 10:39:54 UTC
Created attachment 75069 [details] [review]
conditionaly draw border
Comment 3 Julien MOUTTE 2006-10-20 16:33:25 UTC
Fixed in CVS