GNOME Bugzilla – Bug 363607
xvimagesink xwindow_draw_border() slowness
Last modified: 2006-11-30 22:19:33 UTC
if one sets xvimagesink->keep_aspect=TRUE xvimagsink centers the picture in gst_xvimagesink_xvimage_put(). A few lines down it calls gst_xvimagesink_xwindow_draw_borders(). This is causing quite a slowdown in performance for us (just commenting out the _xwindow_draw_borders() call make it much better). Now the plan is: * first only call _xwindow_draw_borders() if xvimagesink->keep_aspect==TRUE, otherwise there will be no border anyway. * next only do the centering and the border-drawing if the sizes have changed. Finally I belive its up to the ui to paint the background black (or to what ever). So wouldn't it make sense to have a 'draw-border' property (default TRUE), so that if apps handle the sizing, they can paint the border?
maybe its enough to draw the border on the first image and ater expose events (see patch)
Created attachment 75069 [details] [review] conditionaly draw border
Fixed in CVS