After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 363450 - ATK_STATE_DEFAULT needs to be implemented.
ATK_STATE_DEFAULT needs to be implemented.
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: gail
1.12.x
Other All
: Normal normal
: ---
Assigned To: Patrick Wade
Li Yuan
Depends on:
Blocks: 356068
 
 
Reported: 2006-10-19 16:12 UTC by Rich Burridge
Modified: 2008-03-20 09:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (797 bytes, patch)
2007-07-25 02:45 UTC, Li Yuan 		committed Details | Review

Description Rich Burridge 2006-10-19 16:12:43 UTC 
See also Orca bug #356068, which is blocked by this bug.

Latest ATK specification has an AtkState value of 

ATK_STATE_DEFAULT 	 
"Indicates that the object is the "default" active component, i.e. the 
object which is activated by an end-user press of the "Enter" or 
"Return" key. Typically a "close" or "submit" button."

See: http://developer.gnome.org/doc/API/2.0/atk/atk-AtkState.html

This needs to be implemented, so that screen readers like Orca can use it.
Comment 1 bill.haneman 2007-02-14 14:15:18 UTC 
moving to gail, since the state exists in ATK (and is, I believe, exposed by recent Firefox); issue is that gail (probably gailwidget.c) needs to detect this property from gtk+ and expose it.  (I am pretty sure gtk+ exposes the widget property that means "I am the default action for this dialog").
Comment 2 Harry Lu 2007-02-15 09:59:56 UTC 
gtkwidget has a "has-default" property.

I think we can use this property to set the ATK_STATE_DEFAULT state.
Comment 3 Harry Lu 2007-02-16 02:33:22 UTC 
Maybe just calling GTK_WIDGET_HAS_DEFAULT() will work.
Comment 4 Willie Walker 2007-07-24 16:56:11 UTC 
(In reply to comment #3)
> Maybe just calling GTK_WIDGET_HAS_DEFAULT() will work.
> 

Is this something that might be possible in the 2.20 timeframe?
Comment 5 Li Yuan 2007-07-25 02:45:33 UTC 
Created attachment 92320 [details] [review]
patch

Will, can you try the patch? If it is OK, I can commit it. I have tried this on gedit's open file dialog and it works.
Comment 6 Li Yuan 2007-07-25 02:47:01 UTC 
Oh, you can ignore the change in gail/Makefile.am, it is for another bug.
Comment 7 Joanmarie Diggs (IRC: joanie) 2007-07-25 04:50:15 UTC 
I can confirm that this patch causes "is default" to be exposed as a state both for the gedit Open dialog and the Evolution New Contact dialog.
Comment 8 Li Yuan 2007-07-25 07:56:13 UTC 
Thank you. Patch committed.
Comment 9 Willie Walker 2007-07-25 12:07:00 UTC 
I checked it, too.  Looks great!  Thanks!