After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 363445 - Don't use weak references to clean up "const" values in EContact
Don't use weak references to clean up "const" values in EContact
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.8.x (obsolete)
Other Windows
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2006-10-19 15:58 UTC by Ross Burton
Modified: 2006-12-11 16:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.27 KB, patch)
2006-10-19 15:58 UTC, Ross Burton 		committed Details | Review

Description Ross Burton 2006-10-19 15:58:08 UTC 
Weak references are not free and EContact creates a new weak reference for every time e_contact_get_const() returns a new value to clean it up when the object dies.

This is a rather heavyweight way of doing the cleanup, as it can be done fine in finalise.  Attaching a patch to do this.
Comment 1 Ross Burton 2006-10-19 15:58:40 UTC 
Created attachment 75024 [details] [review]
Patch
Comment 2 Karsten Bräckelmann 2006-12-11 16:28:02 UTC 
Please commit to HEAD, after adding a ChangeLog entry.
Comment 3 Ross Burton 2006-12-11 16:35:00 UTC 
Committed, thanks.