GNOME Bugzilla – Bug 363116
Missing label_for/label_by properties in properties dialog
Last modified: 2010-07-06 21:11:40 UTC
Using the at-poke application to examine the widgets in the nautilus application (the app that gives you the folder property window), one can see that the label for and label by properties are not being set. For example, in the Basic tab, the "Type:" label and the actual type label (I see "link to folder" in my window for the file I was looking at) shoudl have a label_for/label_by relations.
Created attachment 74952 [details] [review] patch to add missing relations I hope that the attached patch adds all the missing relations
When I apply this patch, run nautilus, and then look at the window via at-poke, I'm still not seeing any relations. It might be that I've built something wrong, though. Padraig - were you able to see the label_for/by relations after you ran your patched versin of Nautilus?
This is strange. I see loads of new relations when I rebuild nautilus. If you can test on Solaris x86 I can send you a binary.
The problem what that we didn't realize that nautilus was always started when you logged in (i.e., it seems to be the thing that shows the icons on the Desktop). So...to get the new nautilus running, one needs to log out and log back in (or restart nautilus some other way). Once we figured this out, we were able to test this patch and it looks good. Orca gives good information once this patch has been applied. Thanks!
Thanks, I've committed it on HEAD with small changes (an unused variable and an unrelated whitespace change): 2006-10-30 Martin Wehner <martin.wehner@gmail.com> * src/file-manager/fm-properties-window.c: (attach_value_field_internal), (attach_value_field), (attach_ellipsizing_value_field), (append_title_value_pair), (append_title_and_ellipsizing_value), (append_directory_contents_fields), (add_permissions_combo_box), (create_simple_permissions), (create_advanced_permissions): Set up proper relationships between labels and widgets in the properties dialog. Fixes #363116. Patch from Padraig O'Briain <padraig.obriain@sun.com>
Changing component as a part of ongoing reorganisation work.