GNOME Bugzilla – Bug 362922
Icons violating license
Last modified: 2007-01-08 12:22:09 UTC
The new toolbar icons introduced for version 2.17.1 stand in violation with the license: file-roller seems to be GPL 2(+), the tango icons which these icons are based upon licensed under Creative Commons Attribution Share-Alike license, which is not compatible with the GPL. Long story short: the icons can't be shipped with file-roller. Either redo them using GPL components (-> gnome-icon-theme) or (even better) change file-roller to use themable icons.
The CVS version uses themable icons now. Can I ship the icons with file-roller if I distribute them under the terms of the tango icons license, keeping the rest of file-roller under the GPL ?
Right now you seem to install the following icons into the hicolor icon theme: add-files-to-archive add-folder-to-archive extract-archive preview-file First, apps should only put their application icon there, not other icons that are used in the interface. Fore these, you should use a private icon dir (share/file-roller/icons for example). Anyway, the nicest solution would be to have the icons you need added to the icon naming specification and have those icons added to the corresponding theme (gnome-icon-theme, tango-icon-theme) and that's what the Gnome arts people suggest. Feel free to drop in to #tango on the freenode network to discuss what icons need to be added to the spec and the icon-themes.
About private icon dir, I can apply needed changes on cvs (I'm yet working on this for Epiphany). Basically we have to: * add <size>/actions and <size>/apps * put "add*" and "extract*" icons in <size>/actions and install them in ${prefix}/share/file-roller/icons/hicolor/<size>/actions * put "file-roller" icons in <size>/apps and install them in ${prefix}/share/icons/hicolor/<size>/apps (and run gtk-update-icon-cache) * gtk_icon_theme_append_search_path() to add app-specific themable icons All info are now available on wiki: http://live.gnome.org/ThemableAppIcons About the licence, I'll ask on theme list
Created attachment 78535 [details] extract-archive in 16x16 and 22x22 Will take care of 32x32 and 48x48 soon.
I must add that having: add-files-to-archive add-folder-to-archive as two separate items is a bit weird. They basically seem to do the same thing, although you can select a bunch of other actions in the "add to folder" dialog. If you grey out the folder-specific stuff until the user selects a folder I think you can combine the two dialogs. If we do this we can use the list-add action from the icon-theme instead.
BTW the "migration" to themable app-specific icons (see http://live.gnome.org/ThemableAppIcons) is ready and working on my cvs sandbox. The only code code change is this --- src/main.c 5 Nov 2006 18:32:24 -0000 1.51 +++ src/main.c 18 Dec 2006 09:08:43 -0000 @@ -223,6 +223,9 @@ g_set_application_name (_("File Roller")); gtk_window_set_default_icon_name ("file-roller"); + gtk_icon_theme_append_search_path (gtk_icon_theme_get_default (), + FR_DATADIR "/file-roller/icons"); + if (! gnome_vfs_init ()) g_error ("Cannot initialize the Virtual File System."); All other needed changes are related to move image files in a different directory hierarchy: --- configure.in 5 Dec 2006 10:38:36 -0000 1.170 +++ configure.in 18 Dec 2006 09:09:52 -0000 @@ -115,10 +115,20 @@ data/glade/Makefile data/icons/Makefile data/icons/16x16/Makefile +data/icons/16x16/actions/Makefile +data/icons/16x16/apps/Makefile data/icons/22x22/Makefile +data/icons/22x22/actions/Makefile +data/icons/22x22/apps/Makefile data/icons/24x24/Makefile +data/icons/24x24/actions/Makefile +data/icons/24x24/apps/Makefile data/icons/32x32/Makefile +data/icons/32x32/actions/Makefile +data/icons/32x32/apps/Makefile data/icons/scalable/Makefile +data/icons/scalable/actions/Makefile +data/icons/scalable/apps/Makefile src/Makefile src/sh/Makefile nautilus/Makefile
Created attachment 78549 [details] New Makefile.am for Actions context This is the Makefile.am used to manage icons belong to non-Applications context, i.e. icons to install in app-specific hicolor directory
Created attachment 78550 [details] New Makefile.am to install file-roller named icon This is the Makefile.am used to manage icons belong to Applications context, i.e. icons to install in system-wide hicolor directory. The only difference with previous is installation path and icon cache update.
Of course the best way to manage DATADIRS seems: a) define a PKG_DATA_DIR macro b) use it with G_DIR_SEPARATOR_S Also the ICONDIR define seems unuseful in src/Makefile.am =================================================================== RCS file: /cvs/gnome/file-roller/src/Makefile.am,v retrieving revision 1.39 diff -n -u -r1.39 Makefile.am cvs server: conflicting specifications of output style --- src/Makefile.am 5 Nov 2006 18:32:24 -0000 1.39 +++ src/Makefile.am 18 Dec 2006 12:50:30 -0000 @@ -23,9 +23,9 @@ -DFR_SYSCONFDIR=\"$(sysconfdir)\" \ -DFR_DATADIR=\"$(datadir)\" \ -DFR_LIBDIR=\"$(libdir)\" \ + -DPKG_DATA_DIR=\"$(pkgdatadir)\" \ -DPIXMAPSDIR=\""$(datadir)/pixmaps"\" \ -DGLADEDIR=\""$(gladedir)"\" \ - -DICONDIR=\""$(datadir)/file-roller/icons"\" \ -DPRIVEXECDIR=\""$(libexecdir)/file-roller/"\" \ $(DISABLE_DEPRECATED) \ $(FR_CFLAGS) Index: src/main.c =================================================================== RCS file: /cvs/gnome/file-roller/src/main.c,v retrieving revision 1.51 diff -n -u -r1.51 main.c cvs server: conflicting specifications of output style --- src/main.c 5 Nov 2006 18:32:24 -0000 1.51 +++ src/main.c 18 Dec 2006 12:50:30 -0000 @@ -223,6 +223,9 @@ g_set_application_name (_("File Roller")); gtk_window_set_default_icon_name ("file-roller"); + gtk_icon_theme_append_search_path (gtk_icon_theme_get_default (), + PGK_DATA_DIR G_DIR_SEPARATOR_S "icons"); + if (! gnome_vfs_init ()) g_error ("Cannot initialize the Virtual File System.");
patches applied to CVS, thanks Luca.
Paolo, it seems you commited some extraneoud Makefile.in files and some icons outside apps/ or actions/ directories. Take a look at bonsai here[1]. Moreover, changes proposed by myself simply install app-specif icons in a proper way, don't fix the initial issue (GPL vs CC). [1] http://cvs.gnome.org/bonsai/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-12-18+16%3A24&maxdate=2006-12-18+16%3A34&cvsroot=%2Fcvs%2Fgnome
Created attachment 78778 [details] extract-archive in 16x16, 22x22, 32x32 and 48x48 In all sizes now.
Andreas, in the past days Lapo committed some "insert-*" icons on gnome-icon-theme. Maybe we could use a similar metaphon in File Roller. This also means that maybe "insert-file" and "insert-folder" are better names for those named icons. Finally, maybe we neew a "new-archive" named icon for the File->New action (currently we are using the sub-optimal "new-document")
Created attachment 79740 [details] New insert-[image|link|text] icons from gnome-icon-theme Using the same metaphor, the icons to add files and folders in File Roller could show a file and a folder with the same orange triangle on bottom. Moreover, the icon to extract stuff from archive could be an archive with a (blue?) arrow on top, like: /\ <-- the arrow [] <-- the archive